GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Modernise the patchlevel extension by AA-Turner · Pull Request #121995 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jul 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Remove print_function future
  • Use a standard version_info interface
  • Use absolute paths to find patchlevel.h

Note: patchlevel isn't really an extension. Ideally we would make it into one, but there are several uses of version and release in conf.py, so we probably can't at the moment.

  • Issue: Improve and reorganise pyspecific #121970

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
pythonGH-121970: Modernise patchlevel
af4cc37
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news labels Jul 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2024
Improve and reorganise pyspecific #121970
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 18, 2024
@AA-Turner AA-Turner changed the title GH-121970: Modernise patchlevel GH-121970: Modernise the patchlevel extension Jul 18, 2024
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 19, 2024
AA-Turner added 2 commits July 19, 2024 16:47
@AA-Turner
Merge branch 'main' into docs/patchlevel
32ef09a 
# Conflicts:
#	Doc/conf.py
@AA-Turner
Apply Ruff
c1966bf
@AA-Turner
AA-Turner requested review from AlexWaygood and hugovk as code owners July 19, 2024 15:51
@AA-Turner
Formatting niceties
a7c389a
@AA-Turner
AA-Turner enabled auto-merge (squash) July 20, 2024 13:33
@AA-Turner
AA-Turner merged commit b7ad711 into python:main Jul 20, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 20, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 20, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2024
@AA-Turner @miss-islington
pythonGH-121970: Modernise the patchlevel extension (pythonGH-121995)
b16f4d7 
(cherry picked from commit b7ad711)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 20, 2024

Copy link
Copy Markdown

GH-122060 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2024
@AA-Turner @miss-islington
pythonGH-121970: Modernise the patchlevel extension (pythonGH-121995)
f0bebb3 
(cherry picked from commit b7ad711)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 20, 2024
@bedevere-app

bedevere-app Bot commented Jul 20, 2024

Copy link
Copy Markdown

GH-122061 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 20, 2024
AA-Turner added a commit that referenced this pull request Jul 20, 2024
@miss-islington @AA-Turner
[3.12] GH-121970: Modernise the patchlevel extension (GH-121995) (#12…
ca531e4 
…2061)

GH-121970: Modernise the patchlevel extension (GH-121995)
(cherry picked from commit b7ad711)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jul 20, 2024
@miss-islington @AA-Turner
[3.13] GH-121970: Modernise the patchlevel extension (GH-121995) (#12…
efc7d1c 
…2060)

GH-121970: Modernise the patchlevel extension (GH-121995)
(cherry picked from commit b7ad711)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.