GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — bpo-28814: Undeprecate inadvertantly deprecated inspect function. by Carreau · Pull Request #122 · python/cpython Conversation
Contributor
Nick Coghlan said on bpo-28814:
So un-deprecate in the doc, and leave a note to ignore previous
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
ncoghlan
reviewed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accidentally doubled word here: s/with with/with/
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
berkerpeksag
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo: inadvertently
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Ignore previous deprecation notice." is superfluous and can be deleted in my opinion.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Function -> Functions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indentation should use 3 or 4 spaces: .. note::
Functions [...]
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or start with: :func:`~inspect.getargvalues` and :func:`~inspect.formatargvalues` functions were inadvertently [...] I'm not a native speaker so I hope @ncoghlan will chime in here :)
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo: inadvertantly -> inadvertently
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a dot at the end of the sentence.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
berkerpeksag
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks pretty good to me, just left two minor comments :)
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You forgot to end the sentence with a full stop :)
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looking at this again, I think using a note directive is not needed in 3.5 whatsnew page.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you mean removing the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I wasn't clear in my earlier comment. I meant the latter one.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, Done. And full stop added at the end.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsNick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation So un-deprecate in the doc, and leave a note to ignore previous deprecation notice.
berkerpeksag
approved these changes
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
berkerpeksag
pushed a commit
to berkerpeksag/cpython
that referenced
this pull request
…ython#122) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)
berkerpeksag
pushed a commit
to berkerpeksag/cpython
that referenced
this pull request
…ython#122) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
ncoghlan
pushed a commit
that referenced
this pull request
) (#243) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)
ncoghlan
pushed a commit
that referenced
this pull request
) (#244) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
The cache caused false block leak errors from test suite --huntrleaks / -R runs. The performance penalty is irrelevant in debug builds. https://bitbucket.org/stackless-dev/stackless/issues/122
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
jaraco
pushed a commit
that referenced
this pull request
SonicField
added a commit
to SonicField/cpython
that referenced
this pull request
Reinstates block_map_n294_chain at 150 arms (n≈302 BBs) — the wiring fixture that exposed the Phoenix-introduced D-1775660617 RPO un-clamp bug at push 42 (then HALT'd via SIGABRT). Push 43 (4feb0d2) closed the bug; this push restores the canary now that it legitimately PASSes. Test entries: n=0/74/149/200 (low/mid/high-arm + default-miss path coverage), all asserted force_compile + correct execution. Coverage role: - 110-arm fixture (push 41, n≈223 BBs, no resize) — covers below-256 code path - 150-arm fixture (this commit, n≈302 BBs, resize-triggered) — covers >256 code path that GitRPOTraversal + un-clamped wrapper now handle - Together: empirical pair on the same fn-shape exercising both paths of hir_cfg_get_rpo + the cap=4096 paths in pass_output_type_c.c Coverage-Trigger Rule (Phoenix-presumed-regression policy, Alex 13:47:22Z + 13:48:14Z; advisory per supervisor 13:18:54Z): re-grep of parked-bug list (docs/parked-bug-audit-2026-04-24.md Groups A+C; 8 items) against the n≈302 BB fixture surface returns ZERO newly-reachable items (see chat 14:42:05Z for per-item disposition). Push 44 is the rule's first practical test; honoured-in-the-letter at birth. A/B coverage (pythia python#122 python#3 follow-up) discharged STRUCTURALLY per theologian 14:41:27Z: GetRPOTraversal is deterministic on CFG state; the cap parameter controls only caller-buffer write count, not algorithm output. Same-function pre-sized-vs-resize empirical A/B (option i) would require a debug-only cap-setter knob (multi-hour infra) and would add empirical-on-empirical, not new evidence about the determinism claim. Tie-breaking happens INSIDE GetRPOTraversal which receives the CFG, not the caller's output buffer; caller-buffer realloc cannot reach that surface. Pre-commit discipline: bash -n PASS; no C/C++ source touched (push 43 binary 4feb0d2 remains current per testkeeper 14:42:44Z). Auth chain: theologian 13:46:04Z (A/B fold-in proposal) + 14:41:27Z ((ii) APPROVE + structural defense); supervisor 14:39:27Z (push 43 + push 44 plan) + 14:41:00Z (proceed-(ii)-unless-objected); testkeeper pre-commit lint 14:42:44Z; alex 13:47:22Z + 13:48:14Z policy directives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |