GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28814: Undeprecate inadvertantly deprecated inspect function. by Carreau · Pull Request #122 · python/cpython

Conversation

@Carreau

@Carreau Carreau commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

Nick Coghlan said on bpo-28814:

inspect.getargvalues() and inspect.formatargvalues() were deprecated
in Python 3.5 as part of implementing bpo-20438

This is incorrect, as these are frame introspection related functions,
not callable introspection ones. The documentation and implementation
layout is confusing though, as they're interleaved with the callable
introspection operation

So un-deprecate in the doc, and leave a note to ignore previous
deprecation notice.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 15, 2017
@Carreau

Carreau commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

The documentation and implementation
layout is confusing though, as they're interleaved with the callable
introspection operation

I did not touch the code but I'll be happy to move these 2 functions into the "stack frame extraction" section of inspect.py

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan
ncoghlan reviewed Feb 18, 2017
View reviewed changes
Comment thread Doc/whatsnew/3.5.rst Outdated

@ncoghlan ncoghlan Feb 18, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally doubled word here: s/with with/with/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ncoghlan

ncoghlan commented Feb 18, 2017

Copy link
Copy Markdown
Contributor

Thanks! This mostly looks good to me, just one accidentally doubled word to fix before it can be merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag
berkerpeksag requested changes Feb 19, 2017
View reviewed changes
Comment thread Doc/library/inspect.rst Outdated

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: inadvertently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ignore previous deprecation notice." is superfluous and can be deleted in my opinion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/whatsnew/3.5.rst Outdated

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function -> Functions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation should use 3 or 4 spaces:

.. note::
   Functions [...]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or start with:

:func:`~inspect.getargvalues` and :func:`~inspect.formatargvalues` functions were inadvertently [...]

I'm not a native speaker so I hope @ncoghlan will chime in here :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/whatsnew/3.5.rst Outdated

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: inadvertantly -> inadvertently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a dot at the end of the sentence.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Carreau
Carreau force-pushed the undeprecate branch from dbcffb0 to f90fb68 Compare February 20, 2017 23:34
@Carreau

Carreau commented Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

Thanks ! Comments addressed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@berkerpeksag berkerpeksag added needs backport to 3.5 labels Feb 21, 2017
berkerpeksag
berkerpeksag requested changes Feb 21, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, just left two minor comments :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/whatsnew/3.5.rst Outdated

@berkerpeksag berkerpeksag Feb 21, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to end the sentence with a full stop :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/whatsnew/3.5.rst Outdated

@berkerpeksag berkerpeksag Feb 21, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, I think using a note directive is not needed in 3.5 whatsnew page.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Carreau Carreau Feb 21, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean removing the .. note:: altogether along with the text, or just demote the text to a plain paragraph ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@berkerpeksag berkerpeksag Feb 21, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear in my earlier comment. I meant the latter one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Carreau Carreau Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Done. And full stop added at the end.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Carreau
bpo-28814: Undeprecate inadvertantly deprecated inspect function.
e3e6084
Nick Coghlan said on bpo-28814:

> inspect.getargvalues() and inspect.formatargvalues() were deprecated
> in Python 3.5 as part of implementing bpo-20438

> This is incorrect, as these are *frame* introspection related functions,
> not callable introspection ones. The documentation and implementation
> layout is confusing though, as they're interleaved with the callable
> introspection operation

So un-deprecate in the doc, and leave a note to ignore previous
deprecation notice.
@Carreau
Carreau force-pushed the undeprecate branch from f90fb68 to e3e6084 Compare February 22, 2017 03:03
berkerpeksag
berkerpeksag approved these changes Feb 22, 2017
View reviewed changes
@berkerpeksag
berkerpeksag merged commit 0899b98 into python:master Feb 22, 2017
@berkerpeksag

berkerpeksag commented Feb 22, 2017

Copy link
Copy Markdown
Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Carreau

Carreau commented Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

Thanks!

Thanks as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Carreau
Carreau deleted the undeprecate branch February 22, 2017 18:23
berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Feb 22, 2017
@Carreau @berkerpeksag
bpo-28814: Undeprecate inadvertently deprecated inspect functions. (p…
4861158
…ython#122)

Nick Coghlan said on bpo-28814:

> inspect.getargvalues() and inspect.formatargvalues() were deprecated
> in Python 3.5 as part of implementing bpo-20438

> This is incorrect, as these are *frame* introspection related functions,
> not callable introspection ones. The documentation and implementation
> layout is confusing though, as they're interleaved with the callable
> introspection operation

This commit undeprecates these functions and adds a note to ignore
previous deprecation notices.

(cherry picked from commit 0899b98)
@berkerpeksag berkerpeksag removed the needs backport to 3.6 label Feb 22, 2017
berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Feb 22, 2017
@Carreau @berkerpeksag
bpo-28814: Undeprecate inadvertently deprecated inspect functions. (p…
5bb5e93
…ython#122)

Nick Coghlan said on bpo-28814:

> inspect.getargvalues() and inspect.formatargvalues() were deprecated
> in Python 3.5 as part of implementing bpo-20438

> This is incorrect, as these are *frame* introspection related functions,
> not callable introspection ones. The documentation and implementation
> layout is confusing though, as they're interleaved with the callable
> introspection operation

This commit undeprecates these functions and adds a note to ignore
previous deprecation notices.

(cherry picked from commit 0899b98)
@berkerpeksag berkerpeksag removed the needs backport to 3.5 label Feb 22, 2017
@ncoghlan

ncoghlan commented Feb 23, 2017

Copy link
Copy Markdown
Contributor

@berkerpeksag Thanks, you picked up several things I missed :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan pushed a commit that referenced this pull request Feb 23, 2017
@berkerpeksag @ncoghlan
bpo-28814: Undeprecate inadvertently deprecated inspect functions. (#122
2197eac
) (#243)

Nick Coghlan said on bpo-28814:

> inspect.getargvalues() and inspect.formatargvalues() were deprecated
> in Python 3.5 as part of implementing bpo-20438

> This is incorrect, as these are *frame* introspection related functions,
> not callable introspection ones. The documentation and implementation
> layout is confusing though, as they're interleaved with the callable
> introspection operation

This commit undeprecates these functions and adds a note to ignore
previous deprecation notices.

(cherry picked from commit 0899b98)
ncoghlan pushed a commit that referenced this pull request Feb 23, 2017
@berkerpeksag @ncoghlan
bpo-28814: Undeprecate inadvertently deprecated inspect functions. (#122
0246422
) (#244)

Nick Coghlan said on bpo-28814:

> inspect.getargvalues() and inspect.formatargvalues() were deprecated
> in Python 3.5 as part of implementing bpo-20438

> This is incorrect, as these are *frame* introspection related functions,
> not callable introspection ones. The documentation and implementation
> layout is confusing though, as they're interleaved with the callable
> introspection operation

This commit undeprecates these functions and adds a note to ignore
previous deprecation notices.

(cherry picked from commit 0899b98)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#122: Disable the C-stack cache, if Py_REF_DEBUG is defined
72503ea
The cache caused false block leak errors from test suite --huntrleaks / -R runs. The performance penalty is irrelevant in debug builds.

https://bitbucket.org/stackless-dev/stackless/issues/122
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
merge 3.4-slp (Stackless python#122)
8188f4a
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update pytest-asyncio from 0.8.0 to 0.9.0 (#122)
066bbc4
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
@kemier kemier mentioned this pull request Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
@kemier kemier mentioned this pull request Feb 11, 2025
segmentfault when pip installing setuptools #129993
Closed
SonicField added a commit to SonicField/cpython that referenced this pull request Apr 24, 2026
@SonicField
gate_phoenix: reinstate 150-arm fixture (D-1775660617 fix-canary)
cc081f1
Reinstates block_map_n294_chain at 150 arms (n≈302 BBs) — the wiring
fixture that exposed the Phoenix-introduced D-1775660617 RPO un-clamp
bug at push 42 (then HALT'd via SIGABRT). Push 43 (4feb0d2) closed
the bug; this push restores the canary now that it legitimately PASSes.

Test entries: n=0/74/149/200 (low/mid/high-arm + default-miss path
coverage), all asserted force_compile + correct execution.

Coverage role:
  - 110-arm fixture (push 41, n≈223 BBs, no resize) — covers below-256
    code path
  - 150-arm fixture (this commit, n≈302 BBs, resize-triggered) — covers
    >256 code path that GitRPOTraversal + un-clamped wrapper now handle
  - Together: empirical pair on the same fn-shape exercising both paths
    of hir_cfg_get_rpo + the cap=4096 paths in pass_output_type_c.c

Coverage-Trigger Rule (Phoenix-presumed-regression policy, Alex
13:47:22Z + 13:48:14Z; advisory per supervisor 13:18:54Z): re-grep of
parked-bug list (docs/parked-bug-audit-2026-04-24.md Groups A+C; 8 items)
against the n≈302 BB fixture surface returns ZERO newly-reachable items
(see chat 14:42:05Z for per-item disposition). Push 44 is the rule's
first practical test; honoured-in-the-letter at birth.

A/B coverage (pythia python#122 python#3 follow-up) discharged STRUCTURALLY per
theologian 14:41:27Z: GetRPOTraversal is deterministic on CFG state;
the cap parameter controls only caller-buffer write count, not algorithm
output. Same-function pre-sized-vs-resize empirical A/B (option i) would
require a debug-only cap-setter knob (multi-hour infra) and would add
empirical-on-empirical, not new evidence about the determinism claim.
Tie-breaking happens INSIDE GetRPOTraversal which receives the CFG, not
the caller's output buffer; caller-buffer realloc cannot reach that
surface.

Pre-commit discipline: bash -n PASS; no C/C++ source touched (push 43
binary 4feb0d2 remains current per testkeeper 14:42:44Z).

Auth chain: theologian 13:46:04Z (A/B fold-in proposal) + 14:41:27Z
((ii) APPROVE + structural defense); supervisor 14:39:27Z (push 43 +
push 44 plan) + 14:41:00Z (proceed-(ii)-unless-objected); testkeeper
pre-commit lint 14:42:44Z; alex 13:47:22Z + 13:48:14Z policy directives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan left review comments
@berkerpeksag berkerpeksag berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Carreau @ncoghlan @berkerpeksag @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.