GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||
GeezerVison is showing github.com — gh-121999: Change default tarfile filter to 'data' by WilliamRoyNelson · Pull Request #122002 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
29c1861 to
0529960
Compare
0529960 to
c74d0dc
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
CC @encukou, as this is PEP 706. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Tomas R <[email protected]>
d3c2acc to
15216b9
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
1e3001d to
57c60e7
Compare
|
I'm a bit confused but... arae there two people working on this PR simultaneously @WilliamRoyNelson and @sodle? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| .. versionchanged:: 3.14 | ||
| Set the default extraction filter to :func:`data <data_filter>`, | ||
| which disallows dangerous features such as links to absolute paths | ||
| or paths outside of the destination. Previously, the filter strategy |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this one but the outside of now feels weird to me :')
@AA-Turner As a native speaker (you're the only one I know...), should it be "outside the destination", or "outside of"? (or something else entirely?)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I think "outside of" is conventional in North America, less conventional in the UK.
https://learningenglish.voanews.com/a/should-we-think-outside-or-outside-of-the-box-/6434530.html
I think I was reading from PEP 706 when I wrote that update.
Refuse to extract links (hard or soft) which end up linking to a path outside of the destination. (On systems that don’t support links, tarfile will, in most cases, fall back to creating regular files. This proposal doesn’t change that behaviour.)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'll review later this week. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
c3638d4 to
619dc28
Compare
Yeah. Bill is a friend of mine and enlisted my help with writing the tests. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
For the documentation, communicating via GitHub review comments wouldn't be effective, so I took the liberty of pushing a commit to this PR directly. I hope you don't mind. The main themes are:
For shutil: zipfile also has some safeties, though they haven't been reviewed in a while. IMO we can claim for both formats that the defaults “prevent the most dangerous of such security issues”. Does this look good to you? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you for the update! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.