Description

JMCanning78

opened on May 19, 2023

Issue body actions

Documentation

The documentation for TarFile.extraction_filter under "New in version 3.11.4." it states:
"In Python 3.12+, leaving extraction_filter=None will emit a DeprecationWarning.

In Python 3.14+, leaving extraction_filter=None will cause extraction methods to use the data filter by default."

Perhaps this is a forward looking comment about behavior to expect in Python releases 3.12 and 3.14, but I suspect that they should instead be something like "Python 3.11.2+" and "Python 3.11.4+" to document existing behavior.

Linked PRs

• gh-104638: make TarFile.extraction_filter future release references more clear #109908

Activity

1. JMCanning78

   added

   docsDocumentation in the Doc dirDocumentation in the Doc dir

   on May 19, 2023
2. JMCanning78 commented on May 19, 2023

   

   JMCanning78

   on May 19, 2023

   Author

   More actions

   I don't see a way to add labels to this issue, but it should have 3.11 label attached.
3. JelleZijlstra commented on May 19, 2023

   

   JelleZijlstra

   on May 19, 2023

   Member

   More actions

   The text as written is correct: this is the anticipated behavior in 3.12 and 3.14. cc @encukou for tarfile filters.

   Do you have suggestions for how to make this clearer?
4. JMCanning78 commented on May 19, 2023

   

   JMCanning78

   on May 19, 2023

   Author

   More actions

   I guess I don't have a better wording to suggest. When I saw that release 3.13 was skipped, I expected that there was some kind of mistake.
5. zware commented on May 19, 2023

   

   zware

   on May 19, 2023

   Member

   More actions

   Perhaps instead of Python 3.12+, make it Python 3.12 and 3.13?

   Reacted by sunmy2019, John Canning and Robert O'Shea
6. hugovk commented on May 19, 2023

   

   hugovk

   on May 19, 2023

   Member

   More actions

   @JMCanning78 Would you like to make a PR with @zware's suggestion?
7. encukou

   added

   easy

   on Aug 10, 2023
8. serhiy-storchaka

   added this to Tarfile issues 🗄️on Sep 10, 2023
9. hadrizi commented on Sep 25, 2023

   

   hadrizi

   on Sep 25, 2023

   More actions

   @JMCanning78 are you working on this issue? If not @hugovk can I take it?
10. JMCanning78 commented on Sep 25, 2023

    

    JMCanning78

    on Sep 25, 2023

    Author

    More actions

    @hadrizi, thanks for asking. No I am not working on this issue.
11. hugovk commented on Sep 25, 2023

    

    hugovk

    on Sep 25, 2023

    Member

    More actions

    @hadrizi Sure, go for it.

    Reacted by Hadron Collider
12. hadrizi

    added a commit that references this issue on Sep 26, 2023

    pythongh-104638: make `TarFile.extraction_filter` future release refe…

    59f69d7
13. hadrizi commented on Oct 9, 2024

    

    hadrizi

    on Oct 9, 2024

    More actions

    I think this issue is no longer relevant after the changes in #122002

    cc @hugovk @JMCanning78
14. hugovk commented on Oct 9, 2024

    

    hugovk

    on Oct 9, 2024

    Member

    More actions

    Thanks, #122002 removed this bit of text, so let's close this issue and its PR: #109908.
15. hugovk

    closed this as not plannedon Oct 9, 2024
16. github-project-automation

    moved this to Done in Tarfile issues 🗄️on Oct 9, 2024

Issue actions