GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-120754: Add more tests around seek + readall by cmaloney · Pull Request #122103 · python/cpython

Conversation

cmaloney commented Jul 21, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier.

This is part of the improvements from #121593 (comment)

Issue: Speed up open().read() pattern by reducing the number of system calls #120754

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythonGH-120754: Add more tests around seek + readall

0c48c43

In the process of speeding up readall, A number of related tests
(ex. large file tests in test_zipfile) found problems with the
change I was making. This adds I/O tests to specifically test these
cases to help ensure they don't regress and hopefully make debugging
easier.

This is part of the improvements from
python#121593 (comment)

bedevere-app Bot added the tests Tests in the Lib/test dir label

Jul 21, 2024

bedevere-app Bot mentioned this pull request

Jul 21, 2024

Speed up open().read() pattern by reducing the number of system calls #120754

Closed

bedevere-app Bot added the awaiting review label

Jul 21, 2024

cmaloney mentioned this pull request

Jul 21, 2024

GH-120754: Remove isatty call during regular open #121593

Closed

picnixz added the skip news label

Jul 22, 2024

picnixz reviewed

Jul 22, 2024

View reviewed changes

Comment thread

Lib/test/test_largefile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_largefile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

cmaloney and others added 2 commits

July 22, 2024 01:46


          Update Lib/test/test_largefile.py

a01afae

Co-authored-by: Bénédikt Tran <[email protected]>


          Update Lib/test/test_largefile.py

7abd21d

Co-authored-by: Bénédikt Tran <[email protected]>

hauntsaninja approved these changes

Jul 24, 2024

View reviewed changes

hauntsaninja left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cmaloney reacted with hooray emoji

All reactions

🎉 1 reaction

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jul 24, 2024

hauntsaninja added awaiting review needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes and removed awaiting merge labels

Jul 24, 2024

hauntsaninja merged commit 9eb7341 into python:main

Jul 24, 2024

bedevere-app Bot removed the awaiting review label

Jul 24, 2024

miss-islington-app Bot commented Jul 24, 2024

Copy link

Copy Markdown

Thanks @cmaloney for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 24, 2024


          pythonGH-120754: Add more tests around seek + readall (pythonGH-122103)

3ffccc7

In the process of speeding up readall, A number of related tests
(ex. large file tests in test_zipfile) found problems with the
change I was making. This adds I/O tests to specifically test these
cases to help ensure they don't regress and hopefully make debugging
easier.

This is part of the improvements from
https://github.com/python/cpython/pull/121593GH-issuecomment-2222261986
(cherry picked from commit 9eb7341)

Co-authored-by: Cody Maloney <[email protected]>

bedevere-app Bot commented Jul 24, 2024

Copy link

Copy Markdown

GH-122215 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jul 24, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 24, 2024


          pythonGH-120754: Add more tests around seek + readall (pythonGH-122103)

c54e31d

In the process of speeding up readall, A number of related tests
(ex. large file tests in test_zipfile) found problems with the
change I was making. This adds I/O tests to specifically test these
cases to help ensure they don't regress and hopefully make debugging
easier.

This is part of the improvements from
https://github.com/python/cpython/pull/121593GH-issuecomment-2222261986
(cherry picked from commit 9eb7341)

Co-authored-by: Cody Maloney <[email protected]>

bedevere-app Bot commented Jul 24, 2024

Copy link

Copy Markdown

GH-122216 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Jul 24, 2024

cmaloney deleted the cmaloney/largefile_seek_tests branch

July 24, 2024 06:19

hauntsaninja pushed a commit that referenced this pull request

Jul 24, 2024


          [3.12] GH-120754: Add more tests around seek + readall (GH-122103) (#…

9dad694

…122216)

GH-120754: Add more tests around seek + readall (GH-122103)

In the process of speeding up readall, A number of related tests
(ex. large file tests in test_zipfile) found problems with the
change I was making. This adds I/O tests to specifically test these
cases to help ensure they don't regress and hopefully make debugging
easier.

This is part of the improvements from
https://github.com/python/cpython/pull/121593GH-issuecomment-2222261986
(cherry picked from commit 9eb7341)

Co-authored-by: Cody Maloney <[email protected]>

hauntsaninja pushed a commit that referenced this pull request

Jul 24, 2024


          [3.13] GH-120754: Add more tests around seek + readall (GH-122103) (#…

ba3aa5a

…122215)

GH-120754: Add more tests around seek + readall (GH-122103)

In the process of speeding up readall, A number of related tests
(ex. large file tests in test_zipfile) found problems with the
change I was making. This adds I/O tests to specifically test these
cases to help ensure they don't regress and hopefully make debugging
easier.

This is part of the improvements from
https://github.com/python/cpython/pull/121593GH-issuecomment-2222261986
(cherry picked from commit 9eb7341)

Co-authored-by: Cody Maloney <[email protected]>

nohlson pushed a commit to nohlson/cpython that referenced this pull request

Jul 24, 2024


          pythonGH-120754: Add more tests around seek + readall (python#122103)

aae7d34

In the process of speeding up readall, A number of related tests
(ex. large file tests in test_zipfile) found problems with the
change I was making. This adds I/O tests to specifically test these
cases to help ensure they don't regress and hopefully make debugging
easier.

This is part of the improvements from
python#121593 (comment)

nohlson pushed a commit to nohlson/cpython that referenced this pull request

Jul 24, 2024


          pythonGH-120754: Add more tests around seek + readall (python#122103)

72e6ce0

In the process of speeding up readall, A number of related tests
(ex. large file tests in test_zipfile) found problems with the
change I was making. This adds I/O tests to specifically test these
cases to help ensure they don't regress and hopefully make debugging
easier.

This is part of the improvements from
python#121593 (comment)

Reviewers

picnixz

picnixz left review comments

hauntsaninja

hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

cmaloney commented Jul 21, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hauntsaninja left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jul 24, 2024

Uh oh!

bedevere-app Bot commented Jul 24, 2024

Uh oh!

bedevere-app Bot commented Jul 24, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmaloney commented Jul 21, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.