GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Refactor test_capi.test_long by serhiy-storchaka · Pull Request #122113 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 22, 2024

Copy link
Copy Markdown
Member

Share common code for tests for PyLong_As*() functions.

Based on test changes in #120390. The same helper is used in tests for all signed and unsigned integer types. negative_value_error is now an exception class, not a boolean.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @vstinner
Refactor test_capi.test_long
53b9382 
Share common code for tests for PyLong_As*() functions.

Co-authored-by: Victor Stinner <[email protected]>
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 22, 2024
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner July 22, 2024 10:10
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 22, 2024
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 22, 2024
gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64() #120390
Merged
vstinner
vstinner approved these changes Jul 22, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 22, 2024
@serhiy-storchaka
serhiy-storchaka merged commit 69f2dc5 into python:main Jul 22, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 22, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 22, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2024
@serhiy-storchaka @vstinner @miss-islington
Refactor test_capi.test_long (pythonGH-122113)
e4d3e4a 
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 22, 2024

Copy link
Copy Markdown

GH-122137 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 22, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 69f2dc5c06e62b4a9eb4da8f0cd456cc09b998ed 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 22, 2024
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Jul 22, 2024
@serhiy-storchaka

serhiy-storchaka commented Jul 22, 2024

Copy link
Copy Markdown
Member Author

Thank you, Victor.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit that referenced this pull request Jul 23, 2024
@miss-islington @serhiy-storchaka @vstinner
[3.13] Refactor test_capi.test_long (GH-122113) (GH-122137)
4892cc0 
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 23, 2024
@serhiy-storchaka @vstinner
[3.12] Refactor test_capi.test_long (pythonGH-122113)
bf2822f 
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 23, 2024

Copy link
Copy Markdown

GH-122151 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 23, 2024
serhiy-storchaka added a commit that referenced this pull request Jul 23, 2024
@serhiy-storchaka @vstinner
[3.12] Refactor test_capi.test_long (GH-122113) (GH-122151)
b24ca6a 
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Victor Stinner <[email protected]>
@serhiy-storchaka
serhiy-storchaka deleted the test-capi-long branch July 1, 2026 16:47
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.