GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120974: Use common freelist code in asyncio by colesbury · Pull Request #122132 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jul 22, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This refactors asyncio to use the common freelist helper functions and macros. As a side effect, the freelist for _asyncio.Future is now re-enabled in the free-threaded build.

  • Issue: asyncio thread-safety issues in the free-threaded build #120974

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-120974: Use common freelist code in asyncio
21cdcd2 
This refactors asyncio to use the common freelist helper functions and
macros. As a side effect, the freelist for _asyncio.Future is now
re-enabled in the free-threaded build.
@colesbury colesbury added skip news topic-free-threading labels Jul 22, 2024
@colesbury
colesbury requested review from Fidget-Spinner and kumaraditya303 July 22, 2024 17:42
@colesbury
colesbury requested review from 1st1, asvetlov, ericsnowcurrently, gvanrossum and willingc as code owners July 22, 2024 17:42
@bedevere-app bedevere-app Bot mentioned this pull request Jul 22, 2024
asyncio thread-safety issues in the free-threaded build #120974
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 22, 2024
@colesbury

colesbury commented Jul 22, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot Ubuntu refleaks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 22, 2024

Copy link
Copy Markdown

The regex 'Ubuntu refleaks' did not match any buildbot builder. Is the requested builder in the list of stable builders?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury

colesbury commented Jul 22, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot refleaks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 22, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 21cdcd2 🤖

The command will test the builders whose names match following regular expression: refleaks

The builders matched are:

  • AMD64 Windows11 Refleaks PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • s390x RHEL7 Refleaks PR
  • aarch64 Fedora Stable Refleaks PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • PPC64LE CentOS9 Refleaks PR
  • s390x Fedora Refleaks PR
  • AMD64 RHEL8 Refleaks PR
  • aarch64 CentOS9 Refleaks PR
  • s390x RHEL8 Refleaks PR
  • AMD64 CentOS9 Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 Fedora Rawhide Refleaks PR
  • aarch64 RHEL8 Refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • PPC64LE RHEL7 Refleaks PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • aarch64 Fedora Rawhide Refleaks PR
  • AMD64 RHEL7 Refleaks PR
  • AMD64 Fedora Stable Refleaks PR
  • PPC64LE Fedora Stable Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eendebakpt
eendebakpt reviewed Jul 22, 2024
View reviewed changes
Comment thread Objects/object.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Jul 23, 2024
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 23, 2024
Fidget-Spinner
Fidget-Spinner approved these changes Jul 23, 2024
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the new freelist code as well. This LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
kumaraditya303 merged commit c908d1f into python:main Jul 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 23, 2024
@colesbury
colesbury deleted the gh-120974-asyncio-freelist branch July 23, 2024 16:37
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
@colesbury @nohlson
pythongh-120974: Use common freelist code in asyncio (python#122132)
4bb31a1 
This refactors asyncio to use the common freelist helper functions and
macros. As a side effect, the freelist for _asyncio.Future is now
re-enabled in the free-threaded build.
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
@colesbury @nohlson
pythongh-120974: Use common freelist code in asyncio (python#122132)
72ead6a 
This refactors asyncio to use the common freelist helper functions and
macros. As a side effect, the freelist for _asyncio.Future is now
re-enabled in the free-threaded build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eendebakpt eendebakpt eendebakpt left review comments
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@colesbury @bedevere-bot @eendebakpt @Fidget-Spinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.