GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling (GH-122158) by markshannon · Pull Request #122174 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jul 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Cases generator gets confused about the number of values to pop in case of errors in some macros #122155

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
pythonGH-122155: Fix cases generator to correctly compute 'peek' offs…
8a7484b 
…et for error handling (pythonGH-122158)
This was referenced Jul 23, 2024
Cases generator gets confused about the number of values to pop in case of errors in some macros #122155
Closed
GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling #122158
Merged
@bedevere-app bedevere-app Bot added skip news awaiting core review labels Jul 23, 2024
@markshannon
Account for 3.13 differences in test results
5935132
iritkatriel
iritkatriel approved these changes Jul 26, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 26, 2024
@markshannon
markshannon merged commit 9162da2 into python:3.13 Jul 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 26, 2024
@markshannon markshannon mentioned this pull request Jul 26, 2024
Manually override bytecode definition in optimizer, to avoid build error #122316
Merged
@markshannon
markshannon deleted the backport-122158 branch August 6, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.