Description

markshannon

opened on Jul 23, 2024

Issue body actions

Bug report

Bug description:

This input:

        op(FIRST, (x, y -- a, b)) {
            a = x;
            b = y;
        }

        op(SECOND, (a, b -- a, b)) {
        }

        op(THIRD, (j, k --)) {
            ERROR_IF(cond, error);
        }

        macro(TEST) = FIRST + SECOND + THIRD;
        """

Generates:

     ...
     if (cond) goto pop_4_error;
     ...

This should be if (cond) goto pop_2_error;

I noticed this error when working on a fix to #122029, so this isn't just a theoretical bug.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

• GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling #122158
• [3.13] GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling (GH-122158) #122174
• GH-122155: Track local variables between pops and pushes in cases generator #122286

Activity

1. markshannon

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   3.13only security fixesonly security fixes

   3.14bugs and security fixesbugs and security fixes

   on Jul 23, 2024
2. markshannon

   added 2 commits that reference this issue on Jul 23, 2024

   GH-122155: Fix cases generator to correctly compute 'peek' offset for…

   624bda7

   pythonGH-122155: Fix cases generator to correctly compute 'peek' offs…

   8a7484b
3. nohlson

   added 2 commits that reference this issue on Jul 24, 2024

   pythonGH-122155: Fix cases generator to correctly compute 'peek' offs…

   364eb6c

   pythonGH-122155: Fix cases generator to correctly compute 'peek' offs…

   3d74e5b
4. markshannon

   added 2 commits that reference this issue on Jul 26, 2024

   [3.13] GH-122155: Fix cases generator to correctly compute 'peek' off…

   9162da2

   GH-122155: Track local variables between pops and pushes in cases gen…

   a9d56e3
5. markshannon

   closed this as completedon Aug 12, 2024
6. blhsing

   added a commit that references this issue on Aug 22, 2024

   pythonGH-122155: Track local variables between pops and pushes in cas…

   e995f4a

Issue actions