GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122170: Handle `ValueError` raised by `os.stat` in `linecache` by picnixz · Pull Request #122176 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jul 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Interpreter exits on Windows due to ValueError raised in linecache.py #122170

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 2 commits July 23, 2024 15:45
@picnixz
fix linecache
a2142a7
@picnixz
blurb
ca9a493
@bedevere-app bedevere-app Bot mentioned this pull request Jul 23, 2024
Interpreter exits on Windows due to ValueError raised in linecache.py #122170
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 23, 2024
picnixz added 2 commits July 24, 2024 12:35
@picnixz
handle NUL bytes
0b57bb4
@picnixz
update NEWS
7baccdd
@picnixz picnixz changed the title gh-122170: Handle long filenames on Windows platforms in linecache gh-122170: Handle ValueError raised by os.stat in linecache Jul 24, 2024
@picnixz picnixz mentioned this pull request Jul 24, 2024
[Argument Clinic] Change the errors raised by the path_t converter #122228
Closed
@picnixz
picnixz requested a review from serhiy-storchaka July 24, 2024 14:24
picnixz added 2 commits July 24, 2024 16:28
@picnixz
Update NEWS
ea7e0f4
@picnixz
fixup! sphinx!
722946f
@picnixz picnixz added the stdlib Standard Library Python modules in the Lib/ directory label Jul 25, 2024
serhiy-storchaka
serhiy-storchaka reviewed Jul 25, 2024
View reviewed changes
Comment thread Lib/test/test_linecache.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_linecache.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/linecache.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
address review
27eaa98
serhiy-storchaka
serhiy-storchaka reviewed Jul 26, 2024
View reviewed changes
Comment thread Lib/test/test_linecache.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
merge tests
106fcdb
serhiy-storchaka
serhiy-storchaka approved these changes Jul 27, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devdanzin and picnixz reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 27, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) July 27, 2024 10:02
@serhiy-storchaka
serhiy-storchaka merged commit 7a6d4cc into python:main Jul 27, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 27, 2024
@picnixz
picnixz deleted the fix-linecache-valueerror branch July 27, 2024 10:18
@picnixz

picnixz commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

@serhiy-storchaka Should I backport this one to 3.12 and 3.13? (I would say yes)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 27, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 27, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 27, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2024
@picnixz @miss-islington
pythongh-122170: Handle ValueError raised by os.stat() in linecache (p…
84f35b9 
…ythonGH-122176)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 27, 2024

Copy link
Copy Markdown

GH-122348 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2024
@picnixz @miss-islington
pythongh-122170: Handle ValueError raised by os.stat() in linecache (p…
e99304b 
…ythonGH-122176)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 27, 2024

Copy link
Copy Markdown

GH-122349 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 27, 2024
@serhiy-storchaka

serhiy-storchaka commented Jul 27, 2024

Copy link
Copy Markdown
Member

Yes, this can be considered as a bug fix, although very minor.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka pushed a commit that referenced this pull request Jul 27, 2024
@miss-islington @picnixz
[3.12] gh-122170: Handle ValueError raised by os.stat() in linecache (G…
2e37d67 
…H-122176) (GH-122349)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Jul 27, 2024
@miss-islington @picnixz
[3.13] gh-122170: Handle ValueError raised by os.stat() in linecache (G…
3648a94 
…H-122176) (GH-122348)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.