GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-117657: Skip tests that use threads after fork (GH-122194) by miss-islington · Pull Request #122198 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These tests fail when run under thread sanitizer due to the use of fork
and threads.
(cherry picked from commit 64e221d)

Co-authored-by: Sam Gross [email protected]

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury @miss-islington
pythongh-117657: Skip tests that use threads after fork (pythonGH-122194
34dcbb0 
)

These tests fail when run under thread sanitizer due to the use of fork
and threads.
(cherry picked from commit 64e221d)

Co-authored-by: Sam Gross <[email protected]>
@miss-islington
miss-islington requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners July 23, 2024 20:30
@bedevere-app bedevere-app Bot mentioned this pull request Jul 23, 2024
gh-117657: Skip tests that use threads after fork #122194
Merged
@bedevere-app bedevere-app Bot added skip news topic-free-threading labels Jul 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 23, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jul 23, 2024
@colesbury
colesbury enabled auto-merge (squash) July 23, 2024 20:31
@colesbury
colesbury merged commit e0f540d into python:3.13 Jul 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 23, 2024
@miss-islington
miss-islington deleted the backport-64e221d-3.13 branch January 2, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.