GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Skip tests that use threads after fork by colesbury · Pull Request #122194 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jul 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These tests fail when run under thread sanitizer due to the use of fork and threads.

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury colesbury added tests Tests in the Lib/test dir skip news topic-free-threading needs backport to 3.13 only security fixes labels Jul 23, 2024
@colesbury
colesbury requested a review from Fidget-Spinner July 23, 2024 19:43
@colesbury
colesbury requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners July 23, 2024 19:43
@bedevere-app bedevere-app Bot mentioned this pull request Jul 23, 2024
Avoid TSan reported race in run_udp_echo_server #122187
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 23, 2024
@colesbury colesbury changed the title gh-122187: Skip tests that use threads after fork gh-117657: Skip tests that use threads after fork Jul 23, 2024
@colesbury
pythongh-117657: Skip tests that use threads after fork
f67f383 
These tests fail when run under thread sanitizer due to the use of fork
and threads..
@bedevere-app bedevere-app Bot mentioned this pull request Jul 23, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@colesbury
colesbury force-pushed the gh-122187-asyncio-threads-fork branch from f9cfafe to f67f383 Compare July 23, 2024 19:44
@colesbury

colesbury commented Jul 23, 2024

Copy link
Copy Markdown
Contributor Author

Oops, I had the wrong issue number originally. It should be #117657.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
willingc
willingc approved these changes Jul 23, 2024
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @colesbury. Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 23, 2024
@colesbury
colesbury merged commit 64e221d into python:main Jul 23, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 23, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury deleted the gh-122187-asyncio-threads-fork branch July 23, 2024 20:30
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 23, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2024
@colesbury @miss-islington
pythongh-117657: Skip tests that use threads after fork (pythonGH-122194
34dcbb0 
)

These tests fail when run under thread sanitizer due to the use of fork
and threads.
(cherry picked from commit 64e221d)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 23, 2024

Copy link
Copy Markdown

GH-122198 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 23, 2024
colesbury added a commit that referenced this pull request Jul 23, 2024
@miss-islington @colesbury
[3.13] gh-117657: Skip tests that use threads after fork (GH-122194) (#…
e0f540d 
…122198)

These tests fail when run under thread sanitizer due to the use of fork
and threads.
(cherry picked from commit 64e221d)

Co-authored-by: Sam Gross <[email protected]>
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
@colesbury @nohlson
pythongh-117657: Skip tests that use threads after fork (python#122194)
2781b42 
These tests fail when run under thread sanitizer due to the use of fork
and threads.
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
@colesbury @nohlson
pythongh-117657: Skip tests that use threads after fork (python#122194)
efa6eae 
These tests fail when run under thread sanitizer due to the use of fork
and threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @willingc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.