GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119180: Improvements to ForwardRef.evaluate by JelleZijlstra · Pull Request #122210 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jul 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Noticed some issues while writing documentation for this method.

  • Issue: Implement PEP 649 and PEP 749 #119180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-119180: Improvements to ForwardRef.evaluate
fd45f42 
Noticed some issues while writing documentation for this method.
@JelleZijlstra
JelleZijlstra requested a review from AlexWaygood July 24, 2024 04:23
@bedevere-app bedevere-app Bot mentioned this pull request Jul 24, 2024
Implement PEP 649 and PEP 749 #119180
Closed
21 of 30 tasks
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 24, 2024
JelleZijlstra
JelleZijlstra commented Jul 24, 2024
View reviewed changes
Comment thread Lib/annotationlib.py
return value
if owner is None:
owner = self.__owner__
if type_params is None and owner is None:

@JelleZijlstra JelleZijlstra Jul 24, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check felt unnecessarily strict; many ForwardRefs can be evaluated correctly without worrying about type params.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
Fix test
749ca9d
@JelleZijlstra JelleZijlstra added the skip news label Jul 24, 2024
@JelleZijlstra
Merge branch 'main' into pep649-tweaks
2800902
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) August 11, 2024 23:21
@JelleZijlstra
JelleZijlstra merged commit 016f4b5 into python:main Aug 11, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 11, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@JelleZijlstra @blhsing
pythongh-119180: Improvements to ForwardRef.evaluate (python#122210)
7064e0c 
Noticed some issues while writing documentation for this method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.