GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119180: Add evaluate functions for type params and type aliases by JelleZijlstra · Pull Request #122212 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jul 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Implements the following section of PEP 749: https://peps.python.org/pep-0749/#deferred-evaluation-of-pep-695-and-696-objects

  • Issue: Implement PEP 649 and PEP 749 #119180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
JelleZijlstra requested review from carljm, ericsnowcurrently, iritkatriel and markshannon as code owners July 24, 2024 05:23
@bedevere-app bedevere-app Bot mentioned this pull request Jul 24, 2024
Implement PEP 649 and PEP 749 #119180
Closed
21 of 30 tasks
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 24, 2024
@JelleZijlstra
pythongh-119180: Add evaluate functions for type params and type aliases
39b4a57
@JelleZijlstra
JelleZijlstra force-pushed the pep649-typevar2 branch from 902af47 to 39b4a57 Compare July 24, 2024 05:24
@JelleZijlstra
blurb
e01fe40
carljm
carljm approved these changes Jul 26, 2024
View reviewed changes
Comment thread Objects/genericaliasobject.c Outdated

static int
ga_repr_items_list(PyUnicodeWriter *writer, PyObject *p)
ga_repr_items_list(_PyUnicodeWriter *writer, PyObject *p)

@carljm carljm Jul 26, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change from PyUnicodeWriter * to _PyUnicodeWriter * in this signature causes a lot of compiler warnings below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Jul 26, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there was a change to this API since I first wrote the code and I may not have merged properly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 26, 2024
@JelleZijlstra
Fix compiler warnings
742400f
@JelleZijlstra JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 27, 2024
@bedevere-bot

bedevere-bot commented Jul 27, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 742400f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 27, 2024
@JelleZijlstra

JelleZijlstra commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

Going to merge this if the refleak buildbots are happy
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Merge branch 'main' into pep649-typevar2
2f251cf
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) July 27, 2024 16:59
@JelleZijlstra
JelleZijlstra disabled auto-merge July 27, 2024 16:59
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) July 27, 2024 16:59
@JelleZijlstra
JelleZijlstra merged commit ae19226 into python:main Jul 27, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 27, 2024
@sobolevn

sobolevn commented Jul 27, 2024

Copy link
Copy Markdown
Member

I submitted #122362
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @bedevere-bot @sobolevn @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.