GeezerVison is showing github.com — gh-122361: Use proper `PyUnicodeWriter_*` API in `constevaluator_call` by sobolevn · Pull Request #122362 · python/cpython
Conversation
sobolevn
commented
Jul 27, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, thought I got all the warnings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?
Oups, sorry, @picnixz, I missed this question!
I don't really think that it really matters in this use-case :)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
No worry (I also don't think it matters (I didn't know in which context it was being used actually))
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
picnixz
picnixz left review comments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.