GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122237: Fix REPL wrong auto-indentation with comments by HarryLHW · Pull Request #122238 · python/cpython

Conversation

@HarryLHW

@HarryLHW HarryLHW commented Jul 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: REPL auto-indentation is wrong with comments #122237

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@HarryLHW
fix REPL wrong auto-indentation with comments
05efb38
@bedevere-app bedevere-app Bot mentioned this pull request Jul 24, 2024
REPL auto-indentation is wrong with comments #122237
Closed
@HarryLHW

HarryLHW commented Jul 24, 2024

Copy link
Copy Markdown
Contributor Author

At this point, it will never auto-indent if there is only a comment without other code in the last line. This will produce the following situation, and I am trying to fix that if possible.
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JeffersGlass

JeffersGlass commented Jul 28, 2024

Copy link
Copy Markdown
Contributor

At this point, it will never auto-indent if there is only a comment without other code in the last line. This will produce the following situation, and I am trying to fix that if possible.

For what it’s worth, I’m not sure I would consider this a bug. Presumably, the user had to un-indent the comment line deliberately, so I would expect the following line to also be un-indented, if that makes sense.

Are there other situations where this behavior leads to incorrect indentation?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devdanzin devdanzin mentioned this pull request Jul 29, 2024
gh-122237: Fix repl auto indentation wrong with comments #122383
Closed
@ambv

ambv commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

This is fixed already.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal will be requested when the pull request is marked ready for review pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou will be requested when the pull request is marked ready for review lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv will be requested when the pull request is marked ready for review ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@HarryLHW @JeffersGlass @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.