GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122237: Fix repl auto indentation wrong with comments by AnsonTrapani · Pull Request #122383 · python/cpython

Conversation

@AnsonTrapani

@AnsonTrapani AnsonTrapani commented Jul 29, 2024 •
edited by Eclips4
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
  • Issue: REPL auto-indentation is wrong with comments #122237

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AnsonTrapani added 2 commits July 28, 2024 23:50
@AnsonTrapani
fixed auto indentation size for lines with comments
072b3db
@AnsonTrapani
Added test for the indentation of repl input with comments
cf7a627
@AnsonTrapani
AnsonTrapani requested review from ambv, lysnikolaou and pablogsal as code owners July 29, 2024 03:59
@ghost

ghost commented Jul 29, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 29, 2024
REPL auto-indentation is wrong with comments #122237
Closed
@bedevere-app

bedevere-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Jul 29, 2024
@Eclips4 Eclips4 changed the title Fix repl auto indentation wrong with comments: gh-122237 gh-122237: Fix repl auto indentation wrong with comments Jul 29, 2024
@AnsonTrapani
Merge branch 'main' into fix-repl-auto-indentation-wrong-with-comments
852ed7b
@bedevere-app

bedevere-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
ae1455a
@devdanzin

devdanzin commented Jul 29, 2024

Copy link
Copy Markdown
Member

There's also a proposed fix in #122238.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AnsonTrapani
Merge branch 'main' into fix-repl-auto-indentation-wrong-with-comments
d9bffaa
@AnsonTrapani

AnsonTrapani commented Jul 29, 2024

Copy link
Copy Markdown
Author

There's also a proposed fix in #122238.

Hi devdanzin,

Does that one get the priority then or is this merge request going to be closed without a merge? Sorry, this is my first time contributing here so I'm not sure of the procedure!

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233 Wulian233 mentioned this pull request Sep 15, 2024
Pasting a function definition does not work in 3.13 REPL with Windows Terminal #124096
Closed
@terryjreedy

terryjreedy commented Sep 15, 2024

Copy link
Copy Markdown
Member

If two PRs have different solutions, 'priority' is not an issue. (I have not looked at either.) A core dev needs to decide which is superior and merge that, possibly after further changes. Reviewers can test both and give opinions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Fixed in GH-123196.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AnsonTrapani @devdanzin @terryjreedy @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.