GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116322: Fix typo in the #ifdef check by serhiy-storchaka · Pull Request #122268 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Allow C extensions to declare compatibility with free-threading #116322

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-116882: Fix typo in the #ifdef check
30a9ee1
@serhiy-storchaka serhiy-storchaka added the skip news label Jul 25, 2024
@serhiy-storchaka
serhiy-storchaka requested a review from ericsnowcurrently as a code owner July 25, 2024 09:48
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 25, 2024
@serhiy-storchaka serhiy-storchaka changed the title gh-116882: Fix typo in the #ifdef check gh-116322: Fix typo in the #ifdef check Jul 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2024
Allow C extensions to declare compatibility with free-threading #116322
Closed
kumaraditya303
kumaraditya303 approved these changes Jul 25, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 25, 2024
@kumaraditya303
kumaraditya303 merged commit 9bb2e46 into python:main Jul 25, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 25, 2024
@kumaraditya303 kumaraditya303 added the needs backport to 3.13 only security fixes label Jul 25, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 25, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2024
@serhiy-storchaka @miss-islington
pythongh-116322: Fix typo in the GH-ifdef check (pythonGH-122268)
f2060f1 
(cherry picked from commit 9bb2e46)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 25, 2024

Copy link
Copy Markdown

GH-122284 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 25, 2024
@AlexWaygood AlexWaygood mentioned this pull request Jul 25, 2024
gh-116322: Fix typo in moduleobject.c #122282
Closed
kumaraditya303 pushed a commit that referenced this pull request Jul 25, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-116322: Fix typo in the GH-ifdef check (GH-122268) (#122284)
88a96fc 
gh-116322: Fix typo in the GH-ifdef check (GH-122268)
(cherry picked from commit 9bb2e46)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka deleted the Py_GIL_DISABLED branch July 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.