GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121913: Using str(exc) instead of exc.strerror in asyncio.base_events by aisk · Pull Request #122269 · python/cpython

Conversation

@aisk

@aisk aisk commented Jul 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: create_connection and create_server in asyncio didn't work with a Python build with IPv6 disabled #121913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aisk
Using str(exc) instead of exc.strerror in asyncio.base_events
00cfa4b
@aisk
aisk requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners July 25, 2024 10:17
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2024
create_connection and create_server in asyncio didn't work with a Python build with IPv6 disabled #121913
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 25, 2024
@aisk aisk added the skip news label Jul 25, 2024
kumaraditya303
kumaraditya303 approved these changes Jul 25, 2024
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 25, 2024
@kumaraditya303 kumaraditya303 added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes topic-asyncio labels Jul 25, 2024
@kumaraditya303
kumaraditya303 merged commit 070f1e2 into python:main Jul 25, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 25, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 25, 2024

Copy link
Copy Markdown

Thanks @aisk for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2024
@aisk @miss-islington
pythongh-121913: Use str(exc) instead of exc.strerror in `asyncio.bas…
658de64 
…e_events` (pythonGH-122269)

(cherry picked from commit 070f1e2)

Co-authored-by: AN Long <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2024
@aisk @miss-islington
pythongh-121913: Use str(exc) instead of exc.strerror in `asyncio.bas…
602d7ed 
…e_events` (pythonGH-122269)

(cherry picked from commit 070f1e2)

Co-authored-by: AN Long <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 25, 2024

Copy link
Copy Markdown

GH-122278 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 25, 2024
@bedevere-app

bedevere-app Bot commented Jul 25, 2024

Copy link
Copy Markdown

GH-122279 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 25, 2024
kumaraditya303 pushed a commit that referenced this pull request Jul 25, 2024
@miss-islington @aisk
[3.12] gh-121913: Use str(exc) instead of exc.strerror in `asyncio.ba…
0300e33 
…se_events` (GH-122269) (#122279)

gh-121913: Use str(exc) instead of exc.strerror in `asyncio.base_events` (GH-122269)
(cherry picked from commit 070f1e2)

Co-authored-by: AN Long <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Jul 25, 2024
@miss-islington @aisk
[3.13] gh-121913: Use str(exc) instead of exc.strerror in `asyncio.ba…
d1af4f5 
…se_events` (GH-122269) (#122278)

gh-121913: Use str(exc) instead of exc.strerror in `asyncio.base_events` (GH-122269)
(cherry picked from commit 070f1e2)

Co-authored-by: AN Long <[email protected]>
@aisk
aisk deleted the asyncio-disable-ipv6 branch July 25, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@aisk @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.