GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119180: annotationlib: Fix __all__, other minor fixes by JelleZijlstra · Pull Request #122365 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jul 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Implement PEP 649 and PEP 749 #119180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-119180: annotationlib: Fix __all__, reformat, other minor fixes
e7bda02
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood and hugovk as code owners July 27, 2024 19:14
@bedevere-app bedevere-app Bot mentioned this pull request Jul 27, 2024
Implement PEP 649 and PEP 749 #119180
Closed
21 of 30 tasks
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 27, 2024
JelleZijlstra
JelleZijlstra commented Jul 27, 2024
View reviewed changes
Comment thread Lib/annotationlib.py
Comment on lines +13 to +14
"call_evaluate_function",
"get_annotate_function",

@JelleZijlstra JelleZijlstra Jul 27, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two were missing. The rest of the changes in this file are just formatting.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_annotationlib.py
self.assertIs(annotate_func, None)


class TestAnnotationLib(unittest.TestCase):

@JelleZijlstra JelleZijlstra Jul 27, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only non-formatting change in this file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra JelleZijlstra added the skip news label Jul 27, 2024
@JelleZijlstra JelleZijlstra changed the title gh-119180: annotationlib: Fix __all__, reformat, other minor fixes gh-119180: annotationlib: Fix __all__, run Black on annotationlib.py, other minor fixes Jul 27, 2024
AA-Turner
AA-Turner reviewed Jul 27, 2024
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first stdlib module we're proposing to use autoformatting for, is it worth checking on Discourse? Autoformatters are much more opionated than PEP 8, which may be a surprising experience for contributors (note @encukou ran into an issue with a similar tool just whilst making a change to a CPython-only docs extension).

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra

JelleZijlstra commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

I hoped it wouldn't be controversial since we're already doing it for some of the Tools/ code. I'm not interested in discussing this issue on Discourse; if there's disagreement, I'll just take out the autoformatting.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits August 11, 2024 16:19
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep649-cleanup
dca367b
@JelleZijlstra
Back out Black
e9f9714
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) August 11, 2024 23:21
@JelleZijlstra
JelleZijlstra merged commit 4534068 into python:main Aug 11, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 11, 2024
@hugovk hugovk changed the title gh-119180: annotationlib: Fix __all__, run Black on annotationlib.py, other minor fixes gh-119180: annotationlib: Fix __all__, run Black other minor fixes Aug 12, 2024
@hugovk hugovk changed the title gh-119180: annotationlib: Fix __all__, run Black other minor fixes gh-119180: annotationlib: Fix __all__, other minor fixes Aug 12, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@JelleZijlstra @blhsing
pythongh-119180: annotationlib: Fix __all__, formatting (python#122365)
ace7ab9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.