GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-73991: Rework `pathlib.Path.rmtree()` into `delete()` by barneygale · Pull Request #122368 · python/cpython

Conversation

barneygale commented Jul 27, 2024 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Rename pathlib.Path.rmtree() to delete(), and add support for deleting non-directories. This simplifies the interface for users, and nicely complements the upcoming move() and copy() methods (which will also accept any type of file.)

Issue: Support moving across filesystems in pathlib.Path, as shutil.move() does #73991

📚 Documentation preview 📚: https://cpython-previews--122368.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nineteendo reacted with thumbs up emoji

All reactions

👍 1 reaction


          pythonGH-73991: Rework pathlib.Path.rmtree() into delete()

339a85f

Rename `pathlib.Path.rmtree()` to `delete()`, and add support for deleting
non-directories. This simplifies the interface for users, and nicely
complements the upcoming `move()` and `copy()` methods (which will also
accept any type of file.)

barneygale added the topic-pathlib label

Jul 27, 2024

bedevere-app Bot mentioned this pull request

Jul 27, 2024

Support moving across filesystems in pathlib.Path, as shutil.move() does #73991

Closed

AA-Turner reviewed

Jul 27, 2024

View reviewed changes

Comment thread

Doc/library/pathlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

barneygale added 2 commits

July 27, 2024 23:38


          Fix ignore_errors

632279a


          Docs, style.

66609fb

barneygale marked this pull request as ready for review

July 29, 2024 00:10

bedevere-app Bot added the awaiting core review label

Jul 29, 2024

AA-Turner reviewed

Jul 29, 2024

View reviewed changes

AA-Turner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks fine, only one question

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

barneygale reacted with heart emoji

All reactions

❤️ 1 reaction

Comment thread

Doc/library/pathlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/pathlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/pathlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/pathlib/_abc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

barneygale added 2 commits

July 29, 2024 04:16


          Address docs feedback.

b7c72d0


          Shrink overlarge try: block.

f5b788e

barneygale commented Jul 30, 2024

Copy link

Copy Markdown

Contributor Author

@nineteendo I'd welcome your review on this, if you have the time and inclination. No worries if not! Thanks in advance :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nineteendo reviewed

Jul 30, 2024

View reviewed changes

Comment thread

Doc/library/pathlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/pathlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/pathlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

barneygale added 2 commits

July 30, 2024 18:02


          Address some review comments.

fcf1cae


          Move method docs after rmdir and unlink

e9835e0

We generally put the more primitive functions first.

barneygale mentioned this pull request

Jul 31, 2024

GH-73991: Add pathlib.Path.move() #122073

Merged

barneygale requested a review from AA-Turner

August 2, 2024 15:30

barneygale added 4 commits

August 3, 2024 22:11


          Add Path.delete.avoids_symlink_attacks

b84b0e0


          Missing docs def

1e5ad10


          Merge branch 'main' into rename-rmtree-to-delete

4ae320f


          Merge branch 'main' into rename-rmtree-to-delete

549b16c

AA-Turner approved these changes

Aug 7, 2024

View reviewed changes

AA-Turner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Aug 7, 2024

barneygale commented Aug 7, 2024

Copy link

Copy Markdown

Contributor Author

Thank you very much for the reviews :)

AA-Turner reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

barneygale merged commit 98dba73 into python:main

Aug 7, 2024

bedevere-app Bot removed the awaiting merge label

Aug 7, 2024

AA-Turner commented Aug 7, 2024

Copy link

Copy Markdown

Member

Sorry for my tardiness! Do let me know if there's anything else I can usefully review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

barneygale commented Aug 7, 2024

Copy link

Copy Markdown

Contributor Author

Not tardy at all I don't think! :]

Do let me know if there's anything else I can usefully review

Since you're offering, the next PR on the critical path here is #122369. But there's a lot going on there, so feel free to give it a miss or ask me to explain it further / break it up / whatever. Thanks again! And feel free to assign me when you next need a review of something.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood mentioned this pull request

Aug 21, 2024

When should we start accepting PRs for future Python versions python/typeshed#12569

Closed

blhsing pushed a commit to blhsing/cpython that referenced this pull request

Aug 22, 2024


          pythonGH-73991: Rework pathlib.Path.rmtree() into delete() (pytho…

d06605d

…n#122368)

Rename `pathlib.Path.rmtree()` to `delete()`, and add support for deleting
non-directories. This simplifies the interface for users, and nicely
complements the upcoming `move()` and `copy()` methods (which will also
accept any type of file.)

Reviewers

AA-Turner

AA-Turner approved these changes

+1 more reviewer

nineteendo

nineteendo left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

barneygale commented Jul 27, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AA-Turner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barneygale commented Jul 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner left a comment

Choose a reason for hiding this comment

Uh oh!

barneygale commented Aug 7, 2024

Uh oh!

AA-Turner commented Aug 7, 2024

Uh oh!

barneygale commented Aug 7, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

barneygale commented Jul 27, 2024 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.