GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122399: change webbrowser.rst to better describe the contents of controller object by jordibc · Pull Request #122407 · python/cpython

Conversation

@jordibc

@jordibc jordibc commented Jul 29, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a minor change that addresses #122399

It just mentions that the controller object has a name attribute too, before mentioning it with the other methods.

  • Issue: Minor error in the doc for controller.name in the webbrowser documentation page #122399

📚 Documentation preview 📚: https://cpython-previews--122407.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jordibc
webbrowser.rst: better describe the contents of controller object
559b1e9 
This is a minor change that addresses python#122399

It just mentions that the controller object has a `name` attribute too, before mentioning it with the other methods.
@ghost

ghost commented Jul 29, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jul 29, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 29, 2024
Minor error in the doc for controller.name in the webbrowser documentation page #122399
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 29, 2024
AA-Turner
AA-Turner reviewed Jul 29, 2024
View reviewed changes
Comment thread Doc/library/webbrowser.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Fix reference warning
7c9c32c
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 29, 2024
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
hugovk
hugovk approved these changes Apr 10, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 10, 2025
@hugovk
hugovk merged commit 1583f9c into python:main Apr 24, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Apr 24, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 24, 2025

Copy link
Copy Markdown

Thanks @jordibc for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 24, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 24, 2025
@jordibc @AA-Turner @miss-islington
pythongh-122399: change webbrowser.rst to better describe the content…
1ed6783 
…s of controller object (pythonGH-122407)

(cherry picked from commit 1583f9c)

Co-authored-by: Jordi Burguet-Castell <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 24, 2025

Copy link
Copy Markdown

GH-132874 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 24, 2025
hugovk pushed a commit that referenced this pull request Apr 24, 2025
@miss-islington @jordibc @AA-Turner
[3.13] gh-122399: change webbrowser.rst to better describe the conten…
bd4a39f 
…ts of controller object (GH-122407) (#132874)

Co-authored-by: Jordi Burguet-Castell <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments
@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jordibc @hugovk @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.