GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112301: Add argument aliases and tee compiler output for check warnings by nohlson · Pull Request #122465 · python/cpython

Conversation

@nohlson

@nohlson nohlson commented Jul 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This adds argument aliases for the check_warnings.py script per suggestions: #121730 (comment)

Also includes re-adding compiler output to the build_ubuntu job log using tee as suggested: #121730 (comment)

  • Issue: Consider applying flags for warnings about potential security issues #112301

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nohlson
Add argument aliases and tee compiler output for check warnings
b574f0d
@nohlson
nohlson requested review from ezio-melotti and hugovk as code owners July 30, 2024 15:07
@bedevere-app bedevere-app Bot mentioned this pull request Jul 30, 2024
Consider applying flags for warnings about potential security issues #112301
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 30, 2024
@picnixz picnixz mentioned this pull request Jul 30, 2024
gh-112301: Compiler warning management tooling #121730
Merged
@picnixz

picnixz commented Jul 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thank you for addressing my other review! do you want to address #121730 (comment) as well? (i.e. removing the shebang)?

(By the way, thanks for this tool; I was tired of doing it manually)
sethmlarson and nohlson reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Jul 30, 2024
View reviewed changes
Comment thread Tools/build/check_warnings.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz added the skip news label Jul 30, 2024
sethmlarson
sethmlarson approved these changes Jul 30, 2024
View reviewed changes

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense to try to land this one before the others since it impacts compiler outputs for core devs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jul 30, 2024
@nohlson
Remove shebang from the warning check script
c6c7a39
@nohlson

nohlson commented Jul 30, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for addressing my other review! do you want to address #121730 (comment) as well? (i.e. removing the shebang)?

Removed shebang.

(By the way, thanks for this tool; I was tired of doing it manually)

No problem! I am curious what your use case is for running this tool yourself?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware
zware approved these changes Jul 30, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 30, 2024
@zware
zware merged commit 1cac090 into python:main Jul 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 30, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@nohlson @blhsing
pythongh-112301: Add argument aliases and tee compiler output for che…
e7dffc7 
…ck warnings (pythonGH-122465)

Also remove superfluous shebang from the warning check script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@zware zware zware approved these changes
@sethmlarson sethmlarson sethmlarson approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@nohlson @picnixz @zware @sethmlarson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.