GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116622: Skip `PosixPathTest.test_expanduser_pwd2` on platforms which don't support `pwd.getpwall` by mhsmith · Pull Request #122521 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Jul 31, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is consistent with the similar skip in test_pwd.

  • Issue: Add support for Android as a target platform #116622

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith
Skip PosixPathTest.test_expanduser_pwd2 on platforms which don't su…
9ab0f76 
…pport `pwd.getpwall`
@mhsmith mhsmith added skip news needs backport to 3.13 only security fixes labels Jul 31, 2024
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 31, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 31, 2024
Add support for Android as a target platform #116622
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 31, 2024
@mhsmith
mhsmith requested a review from serhiy-storchaka July 31, 2024 13:45
serhiy-storchaka
serhiy-storchaka reviewed Jul 31, 2024
View reviewed changes
Comment thread Lib/test/test_posixpath.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mhsmith
Replace hasattr check with support.get_attribute
a5615a2
@mhsmith
mhsmith requested a review from serhiy-storchaka July 31, 2024 16:25
serhiy-storchaka
serhiy-storchaka approved these changes Jul 31, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 31, 2024
@serhiy-storchaka
serhiy-storchaka merged commit 8844197 into python:main Jul 31, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

Thanks @mhsmith for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 31, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2024
@mhsmith @miss-islington
pythongh-116622: Skip PosixPathTest.test_expanduser_pwd2 on platforms…
2344188 
… which don't support pwd.getpwall (pythonGH-122521)

(cherry picked from commit 8844197)

Co-authored-by: Malcolm Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

GH-122530 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 31, 2024
serhiy-storchaka pushed a commit that referenced this pull request Aug 12, 2024
@miss-islington @mhsmith @freakboy3742
[3.13] gh-116622: Skip PosixPathTest.test_expanduser_pwd2 on platform…
d6d68cf 
…s which don't support pwd.getpwall (GH-122521) (GH-122530)

(cherry picked from commit 8844197)

Co-authored-by: Malcolm Smith <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@mhsmith @blhsing
pythongh-116622: Skip PosixPathTest.test_expanduser_pwd2 on platforms…
f5bdbf7 
… which don't support pwd.getpwall (pythonGH-122521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mhsmith @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.