GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122560: add test that comprehension loop var appears only in one scope of the symtable by iritkatriel · Pull Request #122582 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #122560.

  • Issue: inlined comprehension implementation in symtable - missing test or redundant code #122560

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-122560: add test that comprehension loop var appears only in…
b58bc21 
… one scope of the symtable
@bedevere-app bedevere-app Bot mentioned this pull request Aug 1, 2024
inlined comprehension implementation in symtable - missing test or redundant code #122560
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Aug 1, 2024
@iritkatriel
iritkatriel requested review from JelleZijlstra and carljm August 1, 2024 20:44
@iritkatriel iritkatriel added the skip news label Aug 1, 2024
carljm
carljm approved these changes Aug 2, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 2, 2024
@carljm

carljm commented Aug 2, 2024

Copy link
Copy Markdown
Member

Thanks for cleaning up this missing test coverage!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit fe0a28d into python:main Aug 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 2, 2024
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@iritkatriel @brandtbucher
pythongh-122560: add test that comprehension loop var appears only in…
29952e5 
… one scope of the symtable (python#122582)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@iritkatriel @blhsing
pythongh-122560: add test that comprehension loop var appears only in…
1a51e92 
… one scope of the symtable (python#122582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

inlined comprehension implementation in symtable - missing test or redundant code

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iritkatriel @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.