GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] GH-121970: Fix ``gettext`` for audit events (GH-122651) by miss-islington · Pull Request #122653 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 3, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 95f5c89)

Co-authored-by: Adam Turner [email protected]

  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--122653.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner @miss-islington
pythonGH-121970: Fix gettext for audit events (pythonGH-122651)
358d998 
(cherry picked from commit 95f5c89)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Aug 3, 2024
Improve and reorganise pyspecific #121970
Open
@bedevere-app bedevere-app Bot added the skip news label Aug 3, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 3, 2024
GH-121970: Fix gettext for audit events #122651
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Aug 3, 2024
AA-Turner
AA-Turner approved these changes Aug 3, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 3, 2024
@rffontenelle

rffontenelle commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

Can this be merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Aug 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It needs another committer to review for merging in RC stage.

Context: this PR makes translations work again for .. audit-event:: directives, so is useful for the documentation.

A
rffontenelle reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner requested a review from Yhg1s August 7, 2024 09:35
@Yhg1s
Yhg1s merged commit 4210a7d into python:3.13 Sep 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 2, 2024
@miss-islington
miss-islington deleted the backport-95f5c89-3.13 branch January 2, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @rffontenelle @AA-Turner @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.