GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Fix ``gettext`` for audit events by AA-Turner · Pull Request #122651 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

cc @rffontenelle

This improves upon the previous situation slightly, as now we don't output strings for translation that will never be used (e.g. sys.addaudithook, where the audit-event directive has content.

Fixes #122629.

A

  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--122651.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rffontenelle reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@AA-Turner
Fix gettext for audit events
3a8cb8f
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Aug 3, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 3, 2024
Improve and reorganise pyspecific #121970
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 3, 2024
@AA-Turner AA-Turner mentioned this pull request Aug 3, 2024
Translation strings for auditing events no longer have reST markup #122629
Closed
@AA-Turner
AA-Turner merged commit 95f5c89 into python:main Aug 3, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 3, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 3, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2024
@AA-Turner @miss-islington
pythonGH-121970: Fix gettext for audit events (pythonGH-122651)
358d998 
(cherry picked from commit 95f5c89)

Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2024
@AA-Turner @miss-islington
pythonGH-121970: Fix gettext for audit events (pythonGH-122651)
f833eab 
(cherry picked from commit 95f5c89)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 3, 2024

Copy link
Copy Markdown

GH-122653 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 3, 2024
@AA-Turner
AA-Turner deleted the docs/audit-event-gettext branch August 3, 2024 16:41
@bedevere-app

bedevere-app Bot commented Aug 3, 2024

Copy link
Copy Markdown

GH-122654 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Aug 3, 2024
AA-Turner added a commit that referenced this pull request Aug 3, 2024
@miss-islington @AA-Turner
[3.12] GH-121970: Fix gettext for audit events (GH-122651) (#122654)
8f1b385 
GH-121970: Fix ``gettext`` for audit events (GH-122651)
(cherry picked from commit 95f5c89)

Co-authored-by: Adam Turner <[email protected]>
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@AA-Turner @brandtbucher
pythonGH-121970: Fix gettext for audit events (python#122651)
87bbeba
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@AA-Turner @blhsing
pythonGH-121970: Fix gettext for audit events (python#122651)
52a803f
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
@miss-islington @AA-Turner
[3.13] GH-121970: Fix gettext for audit events (GH-122651) (#122653)
4210a7d 
GH-121970: Fix ``gettext`` for audit events (GH-122651)
(cherry picked from commit 95f5c89)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Translation strings for auditing events no longer have reST markup

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.