GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122686: pin attrs package (for hypothesis workflow) by skirpichev · Pull Request #122687 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Aug 5, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Hypothesis tests on Ubuntu fails in the main #122686

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-122686: pin attrs package (for hypothesis workflow)
2093ea2
@bedevere-app bedevere-app Bot mentioned this pull request Aug 5, 2024
Hypothesis tests on Ubuntu fails in the main #122686
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 5, 2024
@hugovk hugovk added the skip news label Aug 5, 2024
@hugovk

hugovk commented Aug 5, 2024

Copy link
Copy Markdown
Member

Do we still need to pin if upgrading to latest hypothesis==6.108.8?

If so, please can you add a comment as to why we're adding an attrs pin?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Aug 5, 2024

Copy link
Copy Markdown
Member Author

Do we still need to pin if upgrading to latest hypothesis==6.108.8?

Yes, I think so. See:
https://github.com/python/cpython/actions/runs/10246311678/job/28343157458

If so, please can you add a comment as to why we're adding an attrs pin?

I did no debugging, but new release seems broken on the CPython main. Pinning "just works", e.g. (see last commit):
#122682

I'll open issue for attrs and add a comment with reference.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
Add cross-reference for attrs issue
f4bbe0a
vstinner
vstinner approved these changes Aug 5, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/requirements-hypothesis.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 5, 2024
@skirpichev @vstinner
Update Tools/requirements-hypothesis.txt
362bc7a 
Co-authored-by: Victor Stinner <[email protected]>
@skirpichev skirpichev mentioned this pull request Aug 6, 2024
gh-122681: merge m_atan2() and c_atan2() helper functions #122682
Merged
@hugovk
hugovk merged commit 35ae4aa into python:main Aug 6, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 6, 2024
@skirpichev
skirpichev deleted the pin-attrs-122686 branch August 6, 2024 03:58
@hugovk

hugovk commented Aug 6, 2024

Copy link
Copy Markdown
Member

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@skirpichev @vstinner @brandtbucher
pythongh-122686: Pin attrs package (for Hypothesis workflow) (python#…
f8a12de 
…122687)

Co-authored-by: Victor Stinner <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@skirpichev @vstinner @blhsing
pythongh-122686: Pin attrs package (for Hypothesis workflow) (python#…
785718e 
…122687)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@skirpichev @hugovk @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.