GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-121268: remove workarounds for non-IEEE 754 systems in cmath by skirpichev · Pull Request #122716 · python/cpython

Conversation

skirpichev commented Aug 6, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

as now building Python now requires support of IEEE 754 floating point numbers.

Issue: Remove remnants of support for non-IEEE 754 systems from cmathmodule.c #121268

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-121268: remove workarounds for non-IEEE 754 systems in cmath

5aba316

as now building Python now requires support of IEEE 754 floating point
numbers.

bedevere-app Bot mentioned this pull request

Aug 6, 2024

Remove remnants of support for non-IEEE 754 systems from cmathmodule.c #121268

Closed

bedevere-app Bot added the awaiting review label

Aug 6, 2024


          Merge branch 'main' into drop-cmath-legacy-121268

470a59d

kumaraditya303 requested review from mdickinson and serhiy-storchaka

August 6, 2024 07:29

vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Aug 8, 2024

bedevere-bot commented Aug 8, 2024

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 470a59d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Aug 8, 2024

vstinner approved these changes

Aug 8, 2024

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if buildbots are happy with this change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Aug 8, 2024

skirpichev commented Aug 9, 2024

Copy link

Copy Markdown

Member Author

No failures, related to this pr.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner merged commit b6e745a into python:main

Aug 9, 2024

bedevere-app Bot removed the awaiting merge label

Aug 9, 2024

vstinner commented Aug 9, 2024

Copy link

Copy Markdown

Member

Merged, thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev deleted the drop-cmath-legacy-121268 branch

August 9, 2024 09:26

bedevere-bot commented Aug 9, 2024

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit b6e745a.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1380/builds/1044) and take a look at the build logs.
Check if the failure is related to this commit (b6e745a) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1380/builds/1044

Failed tests:

test_socketserver

Failed subtests:

test_UnixDatagramServer - test.test_socketserver.SocketServerTest.test_UnixDatagramServer

Summary of the results of the build (if available):

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 222, in test_UnixDatagramServer
    self.run_server(socketserver.UnixDatagramServer,
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                    socketserver.DatagramRequestHandler,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                    self.dgram_examine)
                    ^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/support/threading_helper.py", line 66, in decorator
    return func(*args)
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 133, in run_server
    testfunc(svrcls.address_family, addr)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 160, in dgram_examine
    buf = data = receive(s, 100)
                 ~~~~~~~^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 43, in receive
    raise RuntimeError("timed out on %r" % (sock,))
RuntimeError: timed out on <socket.socket fd=34, family=1, type=2, proto=0, laddr=./test_python_7aihzq4p.sock>


Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/threading.py", line 1041, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/threading.py", line 992, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 240, in serve_forever
    self._handle_request_noblock()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 320, in _handle_request_noblock
    self.handle_error(request, client_address)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 318, in _handle_request_noblock
    self.process_request(request, client_address)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 349, in process_request
    self.finish_request(request, client_address)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 362, in finish_request
    self.RequestHandlerClass(request, client_address, self)
    ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 763, in __init__
    self.finish()
    ~~~~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 858, in finish
    self.socket.sendto(self.wfile.getvalue(), self.client_address)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 54] Connection reset by peer
ERROR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

blhsing pushed a commit to blhsing/cpython that referenced this pull request

Aug 22, 2024


          pythongh-121268: Remove workarounds for non-IEEE 754 systems in cmath (…

1ec4e47

…python#122716)

As now building Python now requires support of IEEE 754 floating point
numbers.

Reviewers

vstinner

vstinner approved these changes

mdickinson

Awaiting requested review from mdickinson

serhiy-storchaka

Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

skirpichev commented Aug 6, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Aug 8, 2024

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

skirpichev commented Aug 9, 2024

Uh oh!

vstinner commented Aug 9, 2024

Uh oh!

bedevere-bot commented Aug 9, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

skirpichev commented Aug 6, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.