GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-122478: Remove internal frames from tracebacks in REPL (GH-122528) by miss-islington · Pull Request #122817 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Frames of methods in code and codeop modules was show with non-default
sys.excepthook.

Save correct tracebacks in sys.last_traceback and update traceback
attribute of sys.last_value and sys.last_exc.
(cherry picked from commit e73e7a7)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: The new REPL outputs different tracebeck when custom sys.excepthook is used #122478

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
pythongh-122478: Remove internal frames from tracebacks in REPL (pyth…
7716e72 
…onGH-122528)

Frames of methods in code and codeop modules was show with non-default
sys.excepthook.

Save correct tracebacks in sys.last_traceback and update __traceback__
attribute of sys.last_value and sys.last_exc.
(cherry picked from commit e73e7a7)

Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Aug 8, 2024
The new REPL outputs different tracebeck when custom sys.excepthook is used #122478
Closed
gh-122478: Remove internal frames from tracebacks in REPL #122528
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Aug 8, 2024
@serhiy-storchaka
serhiy-storchaka requested review from cfbolz and iritkatriel August 13, 2024 18:27
iritkatriel
iritkatriel reviewed Aug 13, 2024
View reviewed changes
Comment thread Lib/code.py
# over self.write
self._call_excepthook(type, value, tb)
try:
typ, value, tb = sys.exc_info()

@iritkatriel iritkatriel Aug 13, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These days we do exc = sys.exception() and then use exc.__traceback__ and type(exc).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel
iritkatriel approved these changes Aug 13, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 13, 2024
cfbolz
cfbolz approved these changes Aug 13, 2024
View reviewed changes

@cfbolz cfbolz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced Aug 22, 2024
gh-122546: use same filename for different exceptions in new repl #123217
Merged
[3.13] gh-122478: Remove internal frames from tracebacks in REPL (GH-122528) #123227
Merged
@cfbolz

cfbolz commented Aug 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

backport happened in #123227
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cfbolz cfbolz closed this Aug 23, 2024
@miss-islington
miss-islington deleted the backport-e73e7a7-3.13 branch January 2, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfbolz cfbolz cfbolz approved these changes
@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @cfbolz @iritkatriel @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.