GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122546: use same filename for different exceptions in new repl by skirpichev · Pull Request #123217 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Aug 22, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Inconsistency between file names of SyntaxErrors and other Exceptions in the new repl #122546

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-122546: use same filename for different exceptions in new repl
4b6795b
@skirpichev
skirpichev requested review from ambv, lysnikolaou and pablogsal as code owners August 22, 2024 08:31
@bedevere-app bedevere-app Bot mentioned this pull request Aug 22, 2024
Inconsistency between file names of SyntaxErrors and other Exceptions in the new repl #122546
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 22, 2024
@skirpichev
+1
76b80e9
pablogsal
pablogsal approved these changes Aug 22, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 22, 2024
@pablogsal pablogsal added the needs backport to 3.13 only security fixes label Aug 22, 2024
@pablogsal

pablogsal commented Aug 22, 2024

Copy link
Copy Markdown
Member

Thanks for the PR @skirpichev 👌
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 3d7b1a5 into python:main Aug 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 22, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 22, 2024

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Aug 22, 2024

Copy link
Copy Markdown

Sorry, @skirpichev and @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3d7b1a526d858496add5b188c790b8d5fe73b06b 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned pablogsal Aug 22, 2024
@pablogsal

pablogsal commented Aug 22, 2024

Copy link
Copy Markdown
Member

Sorry, @skirpichev and @pablogsal, I could not cleanly backport this to 3.13 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker 3d7b1a526d858496add5b188c790b8d5fe73b06b 3.13

Could you prepare the back port following these instructions?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
skirpichev deleted the exc-filename-122546 branch August 22, 2024 12:03
@skirpichev

skirpichev commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

Could you prepare the back port following these instructions?

I'll try.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cfbolz

cfbolz commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

@skirpichev hold off for a moment. there are various missing other backports which cause the automated backport failures, this one: #122817 and this one: #123062
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added a commit to skirpichev/cpython that referenced this pull request Aug 22, 2024
@skirpichev
[3.13] pythongh-122546: use same filename for different exceptions in…
32bb0f0 
… new repl (pythonGH-123217)

* pythongh-122546: use same filename for different exceptions in new repl

* +1
(cherry picked from commit 3d7b1a5)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 22, 2024

Copy link
Copy Markdown

GH-123226 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 22, 2024
@skirpichev

skirpichev commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

Opened as a draft, just in case it may block other backports.
cfbolz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal pushed a commit that referenced this pull request Aug 22, 2024
@skirpichev
[3.13] gh-122546: use same filename for different exceptions in new r…
5271f8f 
…epl (GH-123217) (#123226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@skirpichev @pablogsal @cfbolz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.