GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117139: Replace _PyList_FromArraySteal with stack ref variant by colesbury · Pull Request #122830 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Aug 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This replaces _PyList_FromArraySteal with _PyList_FromStackRefSteal. It's functionally equivalent, but takes a _PyStackRef array instead of an array of PyObject pointers.

  • Issue: Set up tagged pointers in the evaluation stack #117139

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury @Fidget-Spinner
pythongh-117139: Replace _PyList_FromArraySteal with stack ref variant
47d3235 
This replaces `_PyList_FromArraySteal` with `_PyList_FromStackRefSteal`.
It's functionally equivalent, but takes a `_PyStackRef` array instead of
an array of `PyObject` pointers.

Co-authored-by: Ken Jin <[email protected]>
@colesbury colesbury added the skip news label Aug 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 8, 2024
Set up tagged pointers in the evaluation stack #117139
Closed
@colesbury colesbury added the topic-free-threading label Aug 8, 2024
@colesbury

colesbury commented Aug 8, 2024

Copy link
Copy Markdown
Contributor Author

This was extracted from @Fidget-Spinner's PR:

  • gh-118926: Deferred reference counting GC changes for free threading #121318
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury marked this pull request as ready for review August 8, 2024 17:48
@colesbury
colesbury requested a review from markshannon as a code owner August 8, 2024 17:48
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 8, 2024
@colesbury
colesbury requested review from DinoV and Fidget-Spinner August 8, 2024 17:48
DinoV
DinoV approved these changes Aug 12, 2024
View reviewed changes

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 12, 2024
@colesbury
colesbury merged commit ab094d1 into python:main Aug 12, 2024
@colesbury
colesbury deleted the gh-117139-list-steal branch August 12, 2024 18:49
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 12, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@colesbury @Fidget-Spinner @blhsing
pythongh-117139: Replace _PyList_FromArraySteal with stack ref variant (
d678b1c 
python#122830)

This replaces `_PyList_FromArraySteal` with `_PyList_FromStackRefSteal`.
It's functionally equivalent, but takes a `_PyStackRef` array instead of
an array of `PyObject` pointers.

Co-authored-by: Ken Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoV DinoV DinoV approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @DinoV
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.