GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON (GH-122764) by miss-islington · Pull Request #122842 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
(cherry picked from commit 2f5c3b0)

Co-authored-by: Malcolm Smith [email protected]

  • Issue: Add support for Android as a target platform #116622

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith @miss-islington
pythongh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTH…
63b0faf 
…ON (pythonGH-122764)

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
(cherry picked from commit 2f5c3b0)

Co-authored-by: Malcolm Smith <[email protected]>
@miss-islington
miss-islington requested review from corona10 and erlend-aasland as code owners August 8, 2024 22:01
This was referenced Aug 8, 2024
Add support for Android as a target platform #116622
Closed
gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON #122764
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Aug 8, 2024
erlend-aasland
erlend-aasland approved these changes Aug 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 8, 2024
@gpshead
gpshead merged commit 42005c7 into python:3.13 Aug 9, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 9, 2024
@rgommers rgommers mentioned this pull request Sep 2, 2024
Rebuild for python 3.13 conda-forge/numpy-feedstock#329
Merged
@miss-islington
miss-islington deleted the backport-2f5c3b0-3.13 branch January 2, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @erlend-aasland @gpshead @mhsmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.