GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON by mhsmith · Pull Request #122764 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Aug 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This variable was renamed to MODULE_LDFLAGS in #115780, but as discussed at #115780 (comment), Meson depends on the old name LIBPYTHON. Some other package build scripts probably have the same issue.

  • Issue: Add support for Android as a target platform #116622

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@mhsmith
Rename build variable MODULE_LDFLAGS back to LIBPYTHON
036e340
@mhsmith mhsmith added the needs backport to 3.13 only security fixes label Aug 6, 2024
@mhsmith
mhsmith requested review from corona10 and erlend-aasland as code owners August 6, 2024 23:32
@bedevere-app bedevere-app Bot mentioned this pull request Aug 6, 2024
Add support for Android as a target platform #116622
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 6, 2024
This was referenced Aug 6, 2024
BLD: not all @LIBPYTHON@ changed to @MODULE_LDFLAGS@ #116745
Closed
gh-111225: Link extension modules against libpython on Android #115780
Merged
rgommers
rgommers approved these changes Aug 7, 2024
View reviewed changes

@rgommers rgommers left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix @mhsmith, much appreciated.

I did do a quick check - this rename is complete, no `MODULE_LDFLAGS left except for the news snippet added here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Aug 7, 2024
erlend-aasland
erlend-aasland approved these changes Aug 7, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 7, 2024
@mhsmith

mhsmith commented Aug 8, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland: Thanks; are you able to merge this? There will also be a 3.13 backport.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 2f5c3b0 into python:main Aug 8, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 8, 2024
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
@mhsmith @miss-islington
pythongh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTH…
63b0faf 
…ON (pythonGH-122764)

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
(cherry picked from commit 2f5c3b0)

Co-authored-by: Malcolm Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 8, 2024

Copy link
Copy Markdown

GH-122842 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 8, 2024
gpshead pushed a commit that referenced this pull request Aug 9, 2024
@miss-islington @mhsmith
[3.13] gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYT…
42005c7 
…HON (GH-122764) (GH-122842)

gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON (GH-122764)

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
(cherry picked from commit 2f5c3b0)

Co-authored-by: Malcolm Smith <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@mhsmith @blhsing
pythongh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTH…
479e4bd 
…ON (python#122764)

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
@mhsmith mhsmith mentioned this pull request Sep 30, 2024
Problem building Python 3.12 chaquo/chaquopy#1143
Closed
@lazka

lazka commented Sep 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Could it be that pkg-config is not used on Android? After this the .pc file contains this under cygwin:

Libs: -L${libdir} $(BLDLIBRARY)

which is not valid syntax. I'd assume it is broken under Android too.

edit: (or maybe it was the previous change this tried to fix?)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lazka

lazka commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

yes, also broken for Android, I've filed #138800
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
+1 more reviewer
@rgommers rgommers rgommers approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mhsmith @lazka @rgommers @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.