GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — gh-122873: Allow "python3 -m json" to work by treyhunner · Pull Request #122884 · python/cpython Conversation
|
|
Thank you @AA-Turner for reviewing. Let me know if you'd like any variation of the suggestions I commented on made. I just used blurb to add a NEWS.d entry as well. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
NEWS.d goes into the full changelog, whatsnes is for bigger or user visible changes. Using the same text for both is fine, you've done the right thing here. A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
We do want both. "What's New" is the main set release notes. This'll be the main document people read about the release (~30k views/month): https://docs.python.org/3.14/whatsnew/3.14.html#json NEWS.d files eventually becomes part of the giant changelog, not read so often (~4k views/month), but can be useful to filter via the search box: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Let's also change ./Doc/library/cmdline.rst:
-* :ref:`json.tool <json-commandline>` +* :ref:`json <json-commandline>`
https://cpython-previews--122884.org.readthedocs.build/en/122884/library/cmdline.html
For the What's New and NEWS.d, shall we also mention python -m json explicitly, and include a link to the json-commandline reference?
And there's some json.tool -> json we can update in the Lib/json/__init__.py docstring.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
PR mostly looks good to me, just some comments inline around keeping a minimal level of json.tool documentation (since the submodule still exists and isn't going anywhere).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
There was an error while loading. Please reload this page.
|
I think this is almost ready! Please also change -* :ref:`json.tool <json-commandline>` +* :ref:`json <json-commandline>` https://cpython-previews--122884.org.readthedocs.build/en/122884/library/cmdline.html |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Just updated. I had no idea this page existed. I wish I had known about it when writing my post on Python's CLIs! 😆 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @treyhunner! A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Alyssa Coghlan <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.