GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122903: Honor directories in zipfile.Path.glob. by jaraco · Pull Request #122908 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Aug 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Merge after #122906

  • zipfile.Path.glob fails to match directories #122903: Honor directories in zipfile.Path.glob.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Aug 11, 2024
zipfile.Path.glob fails to match directories #122903
Closed
@jaraco jaraco added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Aug 11, 2024
@jaraco
jaraco force-pushed the bugfix/122903-zipfile-path-glob-directories branch 2 times, most recently from ad7b43e to d319e64 Compare August 11, 2024 23:25
jaraco added 2 commits August 11, 2024 19:55
@jaraco
pythongh-122903: Honor directories in zipfile.Path.glob.
7491195 
Applies changes from zipp v3.19.2 and v3.19.3 (jaraco/zipp#121).
@jaraco
Add blurb
778e6d7
@jaraco
jaraco force-pushed the bugfix/122903-zipfile-path-glob-directories branch from d319e64 to 778e6d7 Compare August 11, 2024 23:56
@jaraco
jaraco marked this pull request as ready for review August 12, 2024 00:01
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 12, 2024
@jaraco
jaraco requested a review from barneygale August 12, 2024 00:07
barneygale
barneygale approved these changes Aug 12, 2024
View reviewed changes

@barneygale barneygale left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jaraco reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 12, 2024
@jaraco

jaraco commented Aug 12, 2024

Copy link
Copy Markdown
Member Author

I added this change to zipp.Path 3.19.3 today and I'm utilizing the fix in another bit of work.

@barneygale I'm interested in your rubber stamp on the change, but also wanted to share related to your recent work on glob generally.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco merged commit 6aa35f3 into python:main Aug 12, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 12, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

Sorry, @jaraco, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6aa35f3002dda25858d47e702e750e2871e42a7c 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned jaraco Aug 12, 2024
@jaraco
jaraco deleted the bugfix/122903-zipfile-path-glob-directories branch August 12, 2024 00:33
@miss-islington-app

miss-islington-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

Sorry, @jaraco, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6aa35f3002dda25858d47e702e750e2871e42a7c 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Aug 12, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2024
@jaraco @miss-islington
pythongh-122903: Honor directories in zipfile.Path.glob. (pythonGH-12…
686818e 
…2908)

(cherry picked from commit 6aa35f3)

Co-authored-by: Jason R. Coombs <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

Sorry, @jaraco, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6aa35f3002dda25858d47e702e750e2871e42a7c 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

GH-122926 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 12, 2024
@bedevere-app

bedevere-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

GH-122927 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Aug 12, 2024
jaraco added a commit to jaraco/cpython that referenced this pull request Aug 12, 2024
@jaraco
[3.12] pythongh-122903: Honor directories in zipfile.Path.glob. (pyth…
5d9f730 
…onGH-122908)

(cherry picked from commit 6aa35f3)

Co-authored-by: Jason R. Coombs <[email protected]>
jaraco pushed a commit that referenced this pull request Aug 12, 2024
@miss-islington
[3.13] gh-122903: Honor directories in zipfile.Path.glob. (GH-122908) (…
59d0d33 
…#122926)

(cherry picked from commit 6aa35f3)
jaraco added a commit that referenced this pull request Aug 12, 2024
@jaraco
[3.12] gh-122903: Honor directories in zipfile.Path.glob. (GH-122908) (…
f511a93 
…#122927)

(cherry picked from commit 6aa35f3)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@jaraco @blhsing
pythongh-122903: Honor directories in zipfile.Path.glob. (python#122908)
2ddd5a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale barneygale approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jaraco jaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jaraco @barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.