GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117139: Garbage collector support for deferred refcounting by colesbury · Pull Request #122956 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Aug 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

  • The free-threaded GC now visits interpreter stacks to keep objects that use deferred reference counting alive.

  • Interpreter frames are zero initialized in the free-threaded GC so that the GC doesn't see garbage data. This is a temporary measure until stack spilling around escaping calls is implemented.

  • Issue: Set up tagged pointers in the evaluation stack #117139

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury @Fidget-Spinner
pythongh-117139: Garbage collector support for deferred refcounting
44d7dff 
* The free-threaded GC now visits interpreter stacks to keep objects
  that use deferred reference counting alive.

* Interpreter frames are zero initialized in the free-threaded GC so
  that the GC doesn't see garbage data. This is a temporary measure
  until stack spilling around escaping calls is implemented.

Co-authored-by: Ken Jin <[email protected]>
@colesbury colesbury added skip news topic-free-threading labels Aug 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 12, 2024
Set up tagged pointers in the evaluation stack #117139
Closed
@colesbury

colesbury commented Aug 12, 2024

Copy link
Copy Markdown
Contributor Author

This was extracted from:

  • gh-118926: Deferred reference counting GC changes for free threading #121318
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury marked this pull request as ready for review August 12, 2024 20:42
@colesbury
colesbury requested a review from Fidget-Spinner as a code owner August 12, 2024 20:42
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 12, 2024
@colesbury
colesbury requested a review from markshannon August 12, 2024 20:42
DinoV
DinoV approved these changes Aug 13, 2024
View reviewed changes

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/gc_free_threading.c Outdated
int
_PyGC_VisitFrameStack(_PyInterpreterFrame *frame, visitproc visit, void *arg)
{
_PyStackRef *ref = frame->localsplus;

@DinoV DinoV Aug 13, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use _PyFrame_GetLocalsArray like the GIL version just to be consistent?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 13, 2024
@colesbury
Use _PyFrame_GetLocalsArray
5b9176b
@colesbury colesbury added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 13, 2024
@bedevere-bot

bedevere-bot commented Aug 13, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 5b9176b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 13, 2024
kumaraditya303
kumaraditya303 reviewed Aug 15, 2024
View reviewed changes
Comment thread Include/internal/pycore_gc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 reviewed Aug 15, 2024
View reviewed changes
Comment thread Python/gc_free_threading.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
Update _PyGC_VisitFrameStack comment
01af213
kumaraditya303
kumaraditya303 approved these changes Aug 15, 2024
View reviewed changes
@colesbury
colesbury enabled auto-merge (squash) August 15, 2024 16:08
@colesbury
colesbury merged commit e001027 into python:main Aug 15, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 15, 2024
@colesbury
colesbury deleted the gh-117139-deferred-gc branch August 15, 2024 16:10
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@colesbury @Fidget-Spinner @blhsing
pythongh-117139: Garbage collector support for deferred refcounting (p…
dd045df 
…ython#122956)

The free-threaded GC now visits interpreter stacks to keep objects
that use deferred reference counting alive.

Interpreter frames are zero initialized in the free-threaded GC so
that the GC doesn't see garbage data. This is a temporary measure
until stack spilling around escaping calls is implemented.

Co-authored-by: Ken Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoV DinoV DinoV approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@colesbury @bedevere-bot @DinoV @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.