GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-109975: Copyedit 3.13 What's New: New Features by AA-Turner · Pull Request #122990 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

A copy-editing pass for new features. Next will be other language changes.

Summary of changes:

  • Move the free-threaded and JIT sections up, though still below pyrepl/improved error messages, as these two will have high end-user impact
  • Update the pyrepl descriptions as Windows is now supported and readline isn't required.
  • Update snippets for error messages to not promote putting multiple statements on one line
  • Significantly update the "free-threaded" section
  • Consolidate and update the JIT section.
    • Is What's New the right place for the fairly detailed description of the Tier 2 architecture / configure options? I note that --enable-experimental-jit isn't mentioned anywhere else in the docs.
  • Move __static_attributes__ to other language changes (just a copy/paste)
  • Rewrap to 80 chars.

As @hugovk mentioned in #109975 (comment), there isn't a great place to link to for the macOS installers currently. I'm not best placed to write that guide though, given I've never owned a Mac!

A

  • Issue: What's New in Python 3.13 (copyediting) #109975

📚 Documentation preview 📚: https://cpython-previews--122990.org.readthedocs.build/en/122990/whatsnew/3.13.html#new-features

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Copyedit New Features
ff24940
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.13 only security fixes labels Aug 13, 2024
@AA-Turner
AA-Turner requested review from Yhg1s and hugovk August 13, 2024 23:22
@bedevere-app bedevere-app Bot mentioned this pull request Aug 13, 2024
What's New in Python 3.13 (copyediting) #109975
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 13, 2024
hugovk
hugovk reviewed Aug 14, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Aug 14, 2024

Copy link
Copy Markdown
Member

@colesbury Please could you check the free-threaded section?

https://cpython-previews--122990.org.readthedocs.build/en/122990/whatsnew/3.13.html#free-threaded-cpython

  • Consolidate and update the JIT section.

    • Is What's New the right place for the fairly detailed description of the Tier 2 architecture / configure options? I note that --enable-experimental-jit isn't mentioned anywhere else in the docs.

Let's ask @brandtbucher. And please could you check the JIT section in general?

https://cpython-previews--122990.org.readthedocs.build/en/122990/whatsnew/3.13.html#a-just-in-time-compiler-for-cpython
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner and others added 3 commits August 14, 2024 10:53
@AA-Turner @hugovk
Apply suggestions from code review
53e5d0f 
Co-authored-by: Hugo van Kemenade <[email protected]>
@AA-Turner
:program: isn't an XRef role
97e5c9e
@AA-Turner
Expand on Android
51cccc2
AA-Turner
AA-Turner commented Aug 14, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury

colesbury commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

The free-threaded section looks good to me.
AA-Turner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Spelling
01b0b41
@hugovk hugovk mentioned this pull request Aug 14, 2024
Adding build Android test in Github Workflow #123016
Closed
Eclips4
Eclips4 reviewed Aug 14, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher
brandtbucher reviewed Aug 15, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher

brandtbucher commented Aug 15, 2024

Copy link
Copy Markdown
Member

The JIT section is accurate. On first read, it did feel a little low-level, but upon re-reading it seems to have a similar level of detail as the linked 3.11 What's New section on the specializing interpreter. I think it's okay, since it provides a basic overview of what happens without getting too in-the-weeds on how it happens. And it gives enough breadcrumbs for those who are looking for more info without overwhelming casual readers.

I'm not opposed to dedication sections in the configure docs (or a dedicated page) on how to use the JIT (though we don't have many actual APIs yet besides an environment variable), but if we do then there should be a big banner that says it's experimental, yadda yadda. I agree though that having the 3.13 What's New be an authoritative user-facing doc on tier two code exectuion isn't ideal... though that's sort of what we did for the specializing interpreter in 3.11, and nobody complained (plus, people are more likely to find the top of the What's New than a dedicated JIT page at this point).

Which is all a very long way of saying: LGTM, but yeah, we might want to document this a bit more somewhere. I personally think the JIT README and this What's New is okay for now, but others may disagree.
AA-Turner and Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner and others added 2 commits August 15, 2024 03:22
@AA-Turner @brandtbucher
Update section title
fa16c3b 
Co-authored-by: Brandt Bucher <[email protected]>
@AA-Turner
Update underline & slightly update title
e5a6a2f
@AA-Turner

AA-Turner commented Aug 15, 2024

Copy link
Copy Markdown
Member Author

LGTM, but yeah, we might want to document this a bit more somewhere. I personally think the JIT README and this What's New is okay for now, but others may disagree.

Sounds good, for now if we're happy to keep it in What's New then that is simplest, and the 3.11 specialising interpreter precedent is helpful.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner requested a review from hugovk August 15, 2024 02:25
hugovk
hugovk approved these changes Aug 15, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think it'd be fine linking to the JIT README.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 15, 2024
@AA-Turner
Cite Tools/jit/README.md
08383bd
hugovk
hugovk approved these changes Aug 15, 2024
View reviewed changes
@AA-Turner
AA-Turner merged commit b106cf8 into python:main Aug 15, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 15, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 15, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2024
@AA-Turner @hugovk
@brandtbucher @miss-islington
pythonGH-109975: Copyedit 3.13 What's New: New Features (pythonGH-122990
ba4ebb1 
)

(cherry picked from commit b106cf8)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 15, 2024

Copy link
Copy Markdown

GH-123032 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner deleted the docs/whatsnew/new-features branch August 15, 2024 09:08
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 15, 2024
@AA-Turner

AA-Turner commented Aug 15, 2024

Copy link
Copy Markdown
Member Author

Thanks all!

A
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added a commit that referenced this pull request Aug 15, 2024
@miss-islington @AA-Turner
@hugovk @brandtbucher
[3.13] GH-109975: Copyedit 3.13 What's New: New Features (GH-122990) (#…
009f9ef 
…123032)

GH-109975: Copyedit 3.13 What's New: New Features (GH-122990)
(cherry picked from commit b106cf8)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Brandt Bucher <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@AA-Turner @hugovk
@brandtbucher @blhsing
pythonGH-109975: Copyedit 3.13 What's New: New Features (python#122990)
e2d0b9c 
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Brandt Bucher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhsmith mhsmith mhsmith left review comments
@brandtbucher brandtbucher brandtbucher left review comments
@Eclips4 Eclips4 Eclips4 left review comments
@hugovk hugovk hugovk approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@AA-Turner @hugovk @colesbury @brandtbucher @mhsmith @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.