GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ensure that iOS test re-runs don't try to spawn a process. by freakboy3742 · Pull Request #122994 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Aug 14, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#122992 added a --rerun option to the iOS testbed... which was then exercised on the run merging to main, revealing that --rerun reruns in a subprocess by default.

This PR also enables the --single-process option, ensuring that reruns are executed in the same process.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
7576457 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@freakboy3742
Ensure that iOS test re-runs don't try to spawn a process.
b3a9e63
@freakboy3742 freakboy3742 added skip issue skip news OS-ios labels Aug 14, 2024
@freakboy3742
freakboy3742 requested a review from ned-deily August 14, 2024 01:20
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 14, 2024
@freakboy3742

freakboy3742 commented Aug 14, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot iOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 14, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit b3a9e63 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ned-deily
ned-deily approved these changes Aug 14, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 14, 2024
@freakboy3742 freakboy3742 mentioned this pull request Aug 14, 2024
Add a --rerun option to the iOS testbed. #122992
Merged
@freakboy3742
freakboy3742 merged commit e03073f into python:main Aug 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 14, 2024
@freakboy3742
freakboy3742 deleted the ios-retry-singleprocess branch August 14, 2024 01:46
@freakboy3742 freakboy3742 mentioned this pull request Aug 14, 2024
[3.13] gh-119727: Add --single-process option to regrtest (#119728) #123010
Merged
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@freakboy3742 @blhsing
Ensure that iOS test re-runs don't try to spawn a process. (python#12…
8e7279b 
…2994)

Adds the --single-process option to the iOS test runner to ensure re-runs execute in the same process.
@freakboy3742 freakboy3742 added the needs backport to 3.13 only security fixes label Aug 27, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 27, 2024

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2024
@freakboy3742 @miss-islington
Ensure that iOS test re-runs don't try to spawn a process. (pythonGH-…
b634ddd 
…122994)

Adds the --single-process option to the iOS test runner to ensure re-runs execute in the same process.
(cherry picked from commit e03073f)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 27, 2024

Copy link
Copy Markdown

GH-123368 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 27, 2024
freakboy3742 added a commit that referenced this pull request Aug 27, 2024
@miss-islington @freakboy3742
[3.13] Ensure that iOS test re-runs don't try to spawn a process. (GH…
fa21b3b 
…-122994) (#123368)

Ensure that iOS test re-runs don't try to spawn a process. (GH-122994)

Adds the --single-process option to the iOS test runner to ensure re-runs execute in the same process.
(cherry picked from commit e03073f)

Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-ios skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@freakboy3742 @bedevere-bot @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.