GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-118093: Turn some `DEOPT_IF`s into `EXIT_IF`s by brandtbucher · Pull Request #122998 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Aug 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This allows us to stitch new traces onto these side-exits, giving us better handling of polymorphism for attribute loads and calls.

About 1% faster. Stats show a notable (~28%) drop in _DEOPT instructions and moderate increases in call and attribute load uops, as expected.

  • Issue: Increase fraction of code executed by tier 2. #118093

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
brandtbucher added 2 commits August 12, 2024 12:40
@brandtbucher
Convert a bunch of deopting instructions into exiting ones
8ff1ad1
@brandtbucher
make regen-all
a0f1853
@brandtbucher brandtbucher added performance Performance or resource usage skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Aug 14, 2024
@brandtbucher brandtbucher self-assigned this Aug 14, 2024
@brandtbucher
brandtbucher requested a review from markshannon as a code owner August 14, 2024 02:58
@bedevere-app bedevere-app Bot mentioned this pull request Aug 14, 2024
Increase fraction of code executed by tier 2. #118093
Closed
2 of 3 tasks
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 14, 2024
markshannon
markshannon approved these changes Aug 14, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 14, 2024
@brandtbucher
brandtbucher merged commit f84754b into python:main Aug 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 14, 2024
@bedevere-bot

bedevere-bot commented Aug 14, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit f84754b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1226/builds/2473) and take a look at the build logs.
  4. Check if the failure is related to this commit (f84754b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1226/builds/2473

Failed tests:

  • test_free_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
Note: switching to 'f84754b70506f03bcbf9fb0265e327d05a1a4b51'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at f84754b705 GH-118093: Turn some DEOPT_IFs into EXIT_IFs (GH-122998)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)

make: *** [Makefile:2304: buildbottest] Error 2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742 freakboy3742 mentioned this pull request Aug 16, 2024
gh-116622: Add Android test script #121595
Merged
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@brandtbucher @blhsing
pythonGH-118093: Turn some DEOPT_IFs into EXIT_IFs (pythonGH-122998)
00d9f4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@brandtbucher @bedevere-bot @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.