GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99108: Inform HACL when explicit_bzero is unavailable by mhsmith · Pull Request #123027 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Aug 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For context, see #99108 (comment).

This PR fixes the build on Android and RHEL7 by defining LINUX_NO_EXPLICIT_BZERO when explicit_bzero is unavailable. It turns out there was already an autoconf check for this function, so I reused it.

Instead of creating a new Makefile variable, I appended the definition to LIBHACL_CFLAGS. This may be useful if HACL uses it in other files in the future.

  • Issue: Replace built-in hashlib with verified implementations from HACL* #99108

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith
Inform HACL whether explicit_bzero is available
c903381
@mhsmith
mhsmith requested review from corona10 and erlend-aasland as code owners August 14, 2024 21:42
@bedevere-app bedevere-app Bot mentioned this pull request Aug 14, 2024
Replace built-in hashlib with verified implementations from HACL* #99108
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 14, 2024
@mhsmith mhsmith added skip news awaiting review and removed awaiting review labels Aug 14, 2024
@mhsmith

mhsmith commented Aug 14, 2024

Copy link
Copy Markdown
Member Author

!buildbot RHEL7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 14, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit c903381 🤖

The command will test the builders whose names match following regular expression: RHEL7

The builders matched are:

  • PPC64LE RHEL7 LTO + PGO PR
  • PPC64LE RHEL7 PR
  • PPC64LE RHEL7 LTO PR
  • AMD64 RHEL7 LTO + PGO PR
  • PPC64LE RHEL7 Refleaks PR
  • AMD64 RHEL7 Refleaks PR
  • AMD64 RHEL7 PR
  • AMD64 RHEL7 LTO PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
msprotz
msprotz approved these changes Aug 14, 2024
View reviewed changes

@msprotz msprotz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that makes a lot of sense. Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Aug 14, 2024
erlend-aasland
erlend-aasland approved these changes Aug 15, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 15, 2024
@encukou
encukou merged commit 3950392 into python:main Aug 15, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 15, 2024
@encukou

encukou commented Aug 15, 2024

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@mhsmith @blhsing
pythongh-99108: Inform HACL when explicit_bzero is unavailable (pytho…
b1029ab 
…nGH-123027)

Inform HACL whether explicit_bzero is available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
+1 more reviewer
@msprotz msprotz msprotz approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mhsmith @bedevere-bot @encukou @msprotz @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.