GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-116608: Revert "[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) (#123051)" by jaraco · Pull Request #123072 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Aug 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 5ac14ee.

This commit should be re-applied after 3.13.0 final.

  • Issue: Un-deprecate functional API for importlib resources & add subdirectory support #116608

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco
[3.13] pythongh-116608: Revert "[3.13] pythongh-116608: Apply style a…
0a058bc 
…nd compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)"

This reverts commit 5ac14ee.

This commit should be re-applied after 3.13.0 final.
@jaraco
jaraco requested review from FFY00 and warsaw as code owners August 16, 2024 15:53
@bedevere-app bedevere-app Bot mentioned this pull request Aug 16, 2024
[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) #123051
Merged
@bedevere-app bedevere-app Bot added the skip news label Aug 16, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 16, 2024
Un-deprecate functional API for importlib resources & add subdirectory support #116608
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 16, 2024
@jaraco
jaraco enabled auto-merge (squash) August 16, 2024 15:59
@jaraco
jaraco disabled auto-merge August 16, 2024 16:11
@jaraco

jaraco commented Aug 16, 2024

Copy link
Copy Markdown
Member Author

I guess technically this change should also be reviewed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco requested review from encukou and removed request for FFY00 and warsaw August 16, 2024 16:12
@FFY00

FFY00 commented Aug 16, 2024

Copy link
Copy Markdown
Member

@jaraco feel free to request a review from me in such cases. I do tend to keep up with the ongoing work in the importlib_metadata and importlib_resources backports, so it might be easier for me to have a look compared to others.
jaraco reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco

jaraco commented Aug 17, 2024

Copy link
Copy Markdown
Member Author

An alternative to approving and merging this change could be to retroactively review and accept the changes for 3.13. I know we wouldn't normally apply such style-sync changes in an RC, but I also note that the AST doesn't change for the non-test code and changes only very modestly in tests. If @encukou would be okay with not applying this PR, that would be my preference.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Aug 19, 2024

Copy link
Copy Markdown
Member

I agree that, since the mistake is made, it's better to keep the style changes in than to revert them and re-introduce later.
@Yhg1s, do you agree?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s

Yhg1s commented Sep 2, 2024

Copy link
Copy Markdown
Member

Yes, the changes seem benign enough that there's no point in reverting and reapplying.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s Yhg1s closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jaraco @FFY00 @encukou @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.