GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) by miss-islington · Pull Request #123051 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 15, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit e913d2c)

Co-authored-by: Jason R. Coombs [email protected]

  • Issue: Un-deprecate functional API for importlib resources & add subdirectory support #116608

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco @miss-islington
pythongh-116608: Apply style and compatibility changes from importlib…
eb4ec55 
…_metadata. (pythonGH-123028)

(cherry picked from commit e913d2c)

Co-authored-by: Jason R. Coombs <[email protected]>
@miss-islington
miss-islington requested review from FFY00, jaraco and warsaw as code owners August 15, 2024 19:32
@bedevere-app bedevere-app Bot mentioned this pull request Aug 15, 2024
gh-116608: Apply style and compatibility changes from importlib_metadata. #123028
Merged
@bedevere-app bedevere-app Bot added the skip news label Aug 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 15, 2024
Un-deprecate functional API for importlib resources & add subdirectory support #116608
Open
@bedevere-app bedevere-app Bot added the awaiting review label Aug 15, 2024
@jaraco jaraco changed the title [3.13] gh-116608: Apply style and compatibility changes from importlib_metadata. (GH-123028) [3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) Aug 15, 2024
@jaraco
jaraco enabled auto-merge (squash) August 15, 2024 19:34
@jaraco
jaraco merged commit 5ac14ee into python:3.13 Aug 15, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Aug 15, 2024
@encukou

encukou commented Aug 16, 2024

Copy link
Copy Markdown
Member

I don't think this is important enough for a release candidate fix.
Are you aware that in the RC phase, all changes need to be reviewed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco

jaraco commented Aug 16, 2024

Copy link
Copy Markdown
Member

Oops. I wasn't aware that we were in RC phase. I guess I'd lost track of time.

I was considering this change blocking for #123037, not because the changes interact, but because when syncing the changes from importlib_resources@cpython to cpython@main, the files get copied wholesale (there's no VCS tracking), and these changes needed to be applied to get those codebases aligned.

I'll revert this change and then re-submit the backport to be blocked on cutting of 3.13.0.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jaraco added a commit to jaraco/cpython that referenced this pull request Aug 16, 2024
@jaraco
Revert "[3.13] pythongh-116608: Apply style and compatibility changes…
7013da1 
… from importlib_resources. (pythonGH-123028) (python#123051)"

This reverts commit 5ac14ee.

This commit should be re-applied after 3.13.0 final.
jaraco added a commit to jaraco/cpython that referenced this pull request Aug 16, 2024
@jaraco
[3.13] pythongh-116608: Revert "[3.13] pythongh-116608: Apply style a…
0a058bc 
…nd compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)"

This reverts commit 5ac14ee.

This commit should be re-applied after 3.13.0 final.
@bedevere-app

bedevere-app Bot commented Aug 16, 2024

Copy link
Copy Markdown

GH-123072 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco

jaraco commented Aug 16, 2024

Copy link
Copy Markdown
Member

#123072 is the revert.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jaraco added a commit to jaraco/cpython that referenced this pull request Aug 16, 2024
@jaraco
[3.13] pythongh-116608: Revert "[3.13] pythongh-116608: Revert "[3.13] …
795033c 
…pythongh-116608: Apply style and compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)""

This reverts commit 0a058bc.
@jaraco jaraco mentioned this pull request Aug 16, 2024
[3.13] gh-116608: Re-apply style and compatibility changes from importlib_resources. (GH-123028) #123074
Closed
@jaraco

jaraco commented Aug 16, 2024

Copy link
Copy Markdown
Member

And #123074 is the revert revert (re-apply) for after 3.13.0.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington deleted the backport-e913d2c-3.13 branch January 2, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @encukou @jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.