GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-123165: make `dis` functions render positions on demand by picnixz · Pull Request #123168 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Aug 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add show_positions keyword argument to dis.dis and related functions #123165

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
add the show_positions formal parameter to dis functions
0fdc1dd
@bedevere-app bedevere-app Bot mentioned this pull request Aug 20, 2024
Add show_positions keyword argument to dis.dis and related functions #123165
Closed
@picnixz picnixz added the skip news label Aug 20, 2024
@picnixz
add dummy _get_positions_width function
3157e24
@picnixz
picnixz force-pushed the dis-show-positions-123165 branch from be826a5 to a934b4e Compare August 20, 2024 11:36
@picnixz
allow to show code's positions in dis
a8eab11
@picnixz
picnixz force-pushed the dis-show-positions-123165 branch from a934b4e to a8eab11 Compare August 20, 2024 11:36
picnixz added 7 commits August 20, 2024 13:37
@picnixz
cosmetic amendments
352c16e
@picnixz
fix detection
6cd65cf
@picnixz
add test
aed2959
@picnixz
simplify tests
2edff6f
@picnixz
add What's New entry
1dd8d67
@picnixz
blurb
4e52413
@picnixz
add docs
7a608e7
@picnixz
picnixz marked this pull request as ready for review August 20, 2024 12:38
@bedevere-app bedevere-app Bot added the awaiting review label Aug 20, 2024
@picnixz picnixz removed the skip news label Aug 20, 2024
picnixz added 4 commits August 20, 2024 14:47
@picnixz
fixup! rst
9c75597
@picnixz
fixup! rst
e14740a
@picnixz
fixup! rst
fe32424
@picnixz
change style
a0dce9c
@picnixz
picnixz requested review from iritkatriel and markshannon August 20, 2024 13:35
iritkatriel
iritkatriel reviewed Aug 20, 2024
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 6 commits August 20, 2024 17:53
@picnixz
address review
b8c1bc8
@picnixz
fix rendering
954a312
@picnixz
fix docs
e908990
@picnixz
fix docstring
df02d44
@picnixz
fix init ordering
c644767
@picnixz
update CLI arg
56bcaef
@picnixz
picnixz requested a review from iritkatriel August 20, 2024 17:25
@picnixz picnixz changed the title gh-123165: add the show_positions formal parameter to dis functions gh-123165: make dis functions render positions on demand Aug 21, 2024
iritkatriel
iritkatriel reviewed Aug 21, 2024
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. A few more comments, nothing major.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 5 commits August 21, 2024 11:32
@picnixz
fix representation
4355fc6
@picnixz
fix f-string
d5d2343
@picnixz
update What's New
760beed
@picnixz
update docs
2356ef5
@picnixz
unify location rendering
ca3cf87
@picnixz
picnixz force-pushed the dis-show-positions-123165 branch from 112fe26 to ca3cf87 Compare August 21, 2024 10:02
@picnixz
keep lineno_width parameter instead
9117895
@picnixz
picnixz force-pushed the dis-show-positions-123165 branch from 548b30f to 9117895 Compare August 21, 2024 10:10
@picnixz picnixz mentioned this pull request Aug 21, 2024
gh-119786: improve internal docs on co_linetable #123198
Merged
iritkatriel
iritkatriel reviewed Aug 21, 2024
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there. Some doc tweaks and a question.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 4 commits August 21, 2024 12:38
@picnixz
address review
d48f759
@picnixz
improve test coverage
860a436
@picnixz
cosmetic adjustements
9dc5ed2
@picnixz
cosmetic adjustements
8d8b145
@picnixz

picnixz commented Aug 21, 2024

Copy link
Copy Markdown
Member Author

I marked your comments as resolved but I hoped I didn't miss any. By the way, thank you very much for your help @iritkatriel!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Aug 21, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 21, 2024
@iritkatriel

iritkatriel commented Aug 21, 2024

Copy link
Copy Markdown
Member

LGTM. @markshannon is this what you had in mind?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Aug 21, 2024

Copy link
Copy Markdown
Member

Yes
picnixz reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit b1d3bd2 into python:main Aug 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 21, 2024
@iritkatriel

iritkatriel commented Aug 21, 2024

Copy link
Copy Markdown
Member

Thank you @picnixz !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz deleted the dis-show-positions-123165 branch August 21, 2024 13:50
@picnixz

picnixz commented Aug 21, 2024

Copy link
Copy Markdown
Member Author

Thank you for your review as well, Irit!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@picnixz @blhsing
pythongh-123165: make dis functions render positions on demand (pyt…
966626a 
…hon#123168)
@picnixz picnixz mentioned this pull request Dec 5, 2024
Add tests for dis command-line interface #127637
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @iritkatriel @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.