GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-122298: Restore printing of GC stats by markshannon · Pull Request #123261 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Aug 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Printing of GC stats was accidentally removed when the GC was changed to incremental.
This PR adds them back.

  • Issue: gc.DEBUG_STATS no longer print out anything #122298

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 2 commits August 23, 2024 11:24
@markshannon
Add collection counts to Py_STATS and add back GC debug printout from…
037d529 
… earlier versions.
@markshannon
Add news
c983f31
@bedevere-app bedevere-app Bot mentioned this pull request Aug 23, 2024
gc.DEBUG_STATS no longer print out anything #122298
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 23, 2024
@markshannon markshannon added 3.13 only security fixes needs backport to 3.13 only security fixes labels Aug 23, 2024
iritkatriel
iritkatriel approved these changes Aug 23, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 23, 2024
@markshannon
markshannon merged commit 7cd3aa4 into python:main Aug 23, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 23, 2024

Copy link
Copy Markdown

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 23, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2024
@markshannon @miss-islington
pythonGH-122298: Restore printing of GC stats (pythonGH-123261)
2579b0d 
(cherry picked from commit 7cd3aa4)

Co-authored-by: Mark Shannon <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 23, 2024

Copy link
Copy Markdown

GH-123268 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 23, 2024
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
@miss-islington @markshannon
[3.13] GH-122298: Restore printing of GC stats (GH-123261) (#123268)
b1372e2 
GH-122298: Restore printing of GC stats (GH-123261)
(cherry picked from commit 7cd3aa4)

Co-authored-by: Mark Shannon <[email protected]>
Yhg1s added a commit to Yhg1s/cpython that referenced this pull request Sep 29, 2024
@Yhg1s
Revert "[3.13] pythonGH-122298: Restore printing of GC stats (pythonG…
8e9333e 
…H-123261) (python#123268)"

This reverts commit b1372e2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13 only security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.