GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101860: document `property.__name__` by picnixz · Pull Request #123399 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Aug 27, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I think I need to change 3.13 What's New since this change was introduced in 3.13. Not sure if Sphinx will complain with how I documented. (waiting for the docs to build to see how it renders)

cc @eltoder @JelleZijlstra

  • Issue: Add __name__ to property #101860

📚 Documentation preview 📚: https://cpython-previews--123399.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
document property.__name__
c3dca6a
@bedevere-app bedevere-app Bot mentioned this pull request Aug 27, 2024
Add __name__ to property #101860
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 27, 2024
JelleZijlstra
JelleZijlstra approved these changes Aug 27, 2024
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Other language changes" doesn't feel like a great location for the news entry, but other changes to builtins are documented there too, so it's the right choice for now.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 27, 2024
@Eclips4 Eclips4 added the needs backport to 3.13 only security fixes label Aug 27, 2024
@encukou
encukou merged commit 40fff90 into python:main Aug 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 28, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2024
@picnixz @miss-islington
pythongh-101860: document property.__name__ (pythonGH-123399)
55ad0e5 
(cherry picked from commit 40fff90)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

GH-123428 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 28, 2024
@picnixz
picnixz deleted the docs/whats-new-3.13-name-property-101860 branch August 28, 2024 14:20
JelleZijlstra pushed a commit that referenced this pull request Aug 29, 2024
@miss-islington @picnixz
[3.13] gh-101860: document property.__name__ (GH-123399) (#123428)
eec25e5 
(cherry picked from commit 40fff90)

Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@picnixz @JelleZijlstra @encukou @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.