GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-123142: fix too wide source location of GET_ITER/GET_AITER by iritkatriel · Pull Request #123420 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Source locations too broad for list comprehension iterable expression #123142

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-123142: fix too wide source location of GET_ITER/GET_AITER
c65d871
@iritkatriel
iritkatriel requested a review from markshannon as a code owner August 28, 2024 11:40
@bedevere-app bedevere-app Bot mentioned this pull request Aug 28, 2024
Source locations too broad for list comprehension iterable expression #123142
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 28, 2024
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes skip news and removed awaiting core review labels Aug 28, 2024
@iritkatriel

iritkatriel commented Aug 28, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Skipping news because the news item from #123173 covers this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon approved these changes Aug 28, 2024
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Nice clean fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting merge label Aug 28, 2024
@iritkatriel
iritkatriel merged commit 61bef62 into python:main Aug 28, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 28, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Sorry, @iritkatriel, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 61bef6245c4a32bf430d684ede8603f423d63284 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned iritkatriel Aug 28, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Sorry, @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 61bef6245c4a32bf430d684ede8603f423d63284 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Aug 28, 2024
@iritkatriel
[3.13] pythongh-123142: fix too wide source location of GET_ITER/GET_…
426c59e 
…AITER (pythonGH-123420).

(cherry picked from commit 61bef62)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

GH-123435 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 28, 2024
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Aug 28, 2024
@iritkatriel
[3.12] pythongh-123142: fix too wide source location of GET_ITER/GET_…
5786bc8 
…AITER (pythonGH-123420).

(cherry picked from commit 61bef62)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

GH-123436 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Aug 28, 2024
iritkatriel added a commit that referenced this pull request Aug 28, 2024
@iritkatriel
[3.13] gh-123142: fix too wide source location of GET_ITER/GET_AITER (G…
d379a92 
…H-123420). (#123435)

(cherry picked from commit 61bef62)
iritkatriel added a commit that referenced this pull request Aug 28, 2024
@iritkatriel
[3.12] gh-123142: fix too wide source location of GET_ITER/GET_AITER (G…
0181aa2 
…H-123420). (#123436)

(cherry picked from commit 61bef62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iritkatriel iritkatriel

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iritkatriel @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.