GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiving on Linux >= 6.10 (GH-120227) by miss-islington · Pull Request #123422 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao [email protected]

  • Issue: test_sendfile_close_peer_in_the_middle_of_receiving fails with Linux 6.10 release candidates and non-4KiB page size #120226

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xry111 @miss-islington
pythongh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiv…
1d684d4 
…ing on Linux >= 6.10 (pythonGH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
@miss-islington
miss-islington requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners August 28, 2024 12:32
@bedevere-app bedevere-app Bot mentioned this pull request Aug 28, 2024
gh-120226: Enlarge DATA to make test_sendfile_close_peer_in_the_middl… #120227
Merged
@bedevere-app bedevere-app Bot added the skip news label Aug 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 28, 2024
test_sendfile_close_peer_in_the_middle_of_receiving fails with Linux 6.10 release candidates and non-4KiB page size #120226
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Aug 28, 2024
vstinner
vstinner approved these changes Aug 28, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 28, 2024
@vstinner
vstinner enabled auto-merge (squash) August 28, 2024 12:33
@vstinner
vstinner merged commit ccc6c2b into python:3.12 Aug 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 28, 2024
@miss-islington
miss-islington deleted the backport-a758424-3.12 branch January 2, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vstinner @xry111
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.