GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120226: Enlarge DATA to make test_sendfile_close_peer_in_the_middl… by xry111 · Pull Request #120227 · python/cpython

Conversation

@xry111

@xry111 xry111 commented Jun 7, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

…e_of_receiving happy with non-4KiB page and Linux >= 6.10

  • Issue: test_sendfile_close_peer_in_the_middle_of_receiving fails with Linux 6.10 release candidates and non-4KiB page size #120226

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xry111
pythongh-120226: Enlarge DATA to make test_sendfile_close_peer_in_the…
431c046 
…_middle_of_receiving happy with non-4KiB page and Linux >= 6.10
@xry111
xry111 requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners June 7, 2024 12:40
@ghost

ghost commented Jun 7, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jun 7, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 7, 2024
test_sendfile_close_peer_in_the_middle_of_receiving fails with Linux 6.10 release candidates and non-4KiB page size #120226
Closed
gvanrossum
gvanrossum approved these changes Jun 7, 2024
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 7, 2024
@gvanrossum gvanrossum added the skip news label Jun 7, 2024
@gvanrossum
gvanrossum merged commit a758424 into python:main Jun 7, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 7, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@xry111 @estyxx
pythongh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiv…
d9b3072 
…ing on Linux >= 6.10 (python#120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
@vstinner vstinner added the needs backport to 3.13 only security fixes label Aug 28, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Thanks @xry111 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2024
@xry111 @miss-islington
pythongh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiv…
1b3f652 
…ing on Linux >= 6.10 (pythonGH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

GH-123421 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 28, 2024
@vstinner vstinner added the needs backport to 3.12 only security fixes label Aug 28, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Thanks @xry111 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2024
@xry111 @miss-islington
pythongh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiv…
1d684d4 
…ing on Linux >= 6.10 (pythonGH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

GH-123422 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Aug 28, 2024
@vstinner

vstinner commented Aug 28, 2024

Copy link
Copy Markdown
Member

Python 3.12 and 3.13 are also affected. I created backports.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner pushed a commit that referenced this pull request Aug 28, 2024
@miss-islington @xry111
[3.12] gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_recei…
ccc6c2b 
…ving on Linux >= 6.10 (GH-120227) (#123422)

gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiving on Linux >= 6.10 (GH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
@miss-islington @xry111
[3.13] gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_recei…
14a899f 
…ving on Linux >= 6.10 (GH-120227) (#123421)

gh-120226: Fix test_sendfile_close_peer_in_the_middle_of_receiving on Linux >= 6.10 (GH-120227)

The worst case is that the kernel buffers 17 pages with a page size of 64k.
(cherry picked from commit a758424)

Co-authored-by: Xi Ruoyao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xry111 @vstinner @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.