GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-123424: add `ZipInfo._for_archive` to set suitable default properties by picnixz · Pull Request #123429 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Aug 28, 2024 •
edited by jaraco
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #123424 .

  • Issue: Extract ZipInfo for archive functionality #123424

📚 Documentation preview 📚: https://cpython-previews--123429.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 5 commits August 28, 2024 16:17
@picnixz
add ZipFile.for_name helper
b95cceb
@picnixz
add tests
4acd888
@picnixz
blurb
d6c594b
@picnixz
add What's New entry
b97016f
@picnixz
update docs
91a421e
@picnixz
picnixz requested a review from jaraco as a code owner August 28, 2024 14:20
@bedevere-app bedevere-app Bot mentioned this pull request Aug 28, 2024
Extract ZipInfo for archive functionality #123424
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Aug 28, 2024
@picnixz
fix tests
2af18d8
jaraco
jaraco reviewed Aug 28, 2024
View reviewed changes

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have some thoughts about alternative approaches. Interested to hear what you think.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/zipfile/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/zipfile/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233

Wulian233 commented Nov 2, 2024

Copy link
Copy Markdown
Contributor

Is there anything else that needs to be changed/discussion in this PR? I had another PR #124435 (which has been completed) that conflicted with these changes.

After merge, I can continue handle my PR :)

#124435 (review)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Nov 2, 2024

Copy link
Copy Markdown
Member Author

I don't have time for this one sorry. I didn't implement the suggestion with composition due to other issues that seemed more pressing (and I don't plan to come back here before I'm done with providing HACL* HMAC, at least).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco self-assigned this Dec 29, 2024
jaraco added 2 commits December 29, 2024 12:33
@jaraco
Merge branch 'main' into feat/zipfile-for-name-123424
a8f6a9f
@jaraco
To avoid passthrough parameters, use _for_archive to mutate a constru…
44e7b75 
…cted ZipInfo.
@jaraco
jaraco force-pushed the feat/zipfile-for-name-123424 branch from f578f66 to 44e7b75 Compare December 29, 2024 18:07
jaraco
jaraco approved these changes Dec 29, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 29, 2024
@jaraco jaraco changed the title gh-123424: add ZipInfo.for_name to construct a ZipInfo for a file in an archive gh-123424: add ZipInfo._for_archive to set suitable default properties Dec 29, 2024
@jaraco
jaraco enabled auto-merge (squash) December 29, 2024 18:23
@jaraco
jaraco merged commit 7e819ce into python:main Dec 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 29, 2024
@picnixz

picnixz commented Dec 31, 2024

Copy link
Copy Markdown
Member Author

Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz deleted the feat/zipfile-for-name-123424 branch December 31, 2024 17:27
@jaraco

jaraco commented Dec 31, 2024

Copy link
Copy Markdown
Member

Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

No need to apologize. Thanks for the original work and being proactive about your availability.
picnixz reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz @jaraco @srinivasreddy
pythongh-123424: add ZipInfo._for_archive to set suitable default p…
7c0567d 
…roperties (python#123429)

---------

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco jaraco mentioned this pull request May 12, 2025
Backport ZipInfo._for_archive functionality jaraco/zipp#141
Closed
jaraco added a commit to jaraco/zipp that referenced this pull request May 12, 2025
@picnixz @jaraco
Cherry-pick changes from python/cpython#123429.
bc37b6e 
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties

---------

Co-authored-by: Jason R. Coombs <[email protected]>
jaraco added a commit to jaraco/zipp that referenced this pull request May 12, 2025
@picnixz @jaraco
Cherry-pick changes from python/cpython#123429.
511a7a3 
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties

---------

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco jaraco mentioned this pull request May 26, 2025
Backport gh-123429 jaraco/zipp#142
Merged
jaraco added a commit to jaraco/zipp that referenced this pull request May 26, 2025
@jaraco
Merge pull request #142 from jaraco/backport-gh-123429
73cdd55 
Backport python/cpython#123429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jaraco jaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extract ZipInfo for archive functionality

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @Wulian233 @jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.